fix: exclude .eslintignore, .prettierignore and .graphql files #1252
Conversation
|
SamuelAlev
requested review from
fulopdaniel,
peter-tudosa and
ragi96
and removed request for
anxobotana,
hochreutenerl and
imoutaharik
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a deployment issue by excluding specific file types that aren't supported by the Frontify Marketplace from the deployment package.
- Updates the SOURCE_FILE_BLOCK_LIST to exclude .eslintignore, .prettierignore, and .graphql files
- Modifies the path processing logic to handle glob patterns properly when converting paths
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| const sourceFilesToIgnore = [...gitignoreEntries, ...SOURCE_FILE_BLOCK_LIST].map((path) => { | ||
| if (path.includes('*')) { | ||
| return `${projectPath}/${path}`; | ||
| } | ||
| return fastGlob.convertPathToPattern(`${projectPath}/${path}`); | ||
| }); |
There was a problem hiding this comment.
The condition path.includes('*') is too broad and could incorrectly identify non-glob patterns. For example, a file named 'my*file.txt' would be treated as a glob pattern. Consider using a more precise check like path.includes('**') || path.includes('*.') or use a proper glob pattern detection method.
ragi96
requested review from
julianiff and
mike85
and removed request for
fulopdaniel and
ragi96
5 participants
The issue occurred because .eslintignore, .prettierignore, and .graphql files were being included in the deployment package, but the Frontify Marketplace doesn't support this file extension for source files.