Skip to content

Conversation

@anxobotana
Copy link
Contributor

We are getting this error for a client trying to deploy a new Theme. The error doesn't help much. Let's show a better message depending on what's there.

 The deployment has failed and was aborted due to an error: TypeError: Cannot read properties of undefined (reading 'error')

Note for reviewers: if you think it's not needed feel free to close the PR

@anxobotana anxobotana requested review from a team as code owners July 17, 2025 11:35
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2025

🦋 Changeset detected

Latest commit: e3b89f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@frontify/frontify-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anxobotana anxobotana changed the title fix: better logs on deploy error feat: better logs on deploy error Jul 17, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'CLI'

Failed conditions
1 New Critical Issues (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Collaborator

@ragi96 ragi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kenny806 Kenny806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anxobotana anxobotana merged commit 75880c6 into main Jul 17, 2025
2 of 3 checks passed
@anxobotana anxobotana deleted the fix/deploy-error-messsage branch July 17, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants