-
Notifications
You must be signed in to change notification settings - Fork 4
chore: bump node to v22 #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump node to v22 #1278
Conversation
|
ragi96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test the cli and everything if it works fine?
CLI has its own .nvmrc that is still 18. As far as I know the only thing changed here is the github CI actions node version. It's needed for updating fondue to v13. |
Does the CI still work, as it could break, if the workflows are not properly set up (as using on nvmrc what is kind of special imo and workflow may only takes the one you adjusted now) |
I mean is there a way to test that locally? :D I think it should be fine, but would love to hear your opinion on how to make sure. |
marguslant0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
|
|
This reverts commit a847a63.
ragi96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤞



No description provided.