Skip to content

Conversation

@fulopdaniel
Copy link
Contributor

@fulopdaniel fulopdaniel commented Sep 1, 2025

No description provided.

@fulopdaniel fulopdaniel requested a review from ragi96 September 1, 2025 11:54
@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2025

⚠️ No Changeset found

Latest commit: d3ffeb9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@ragi96 ragi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test the cli and everything if it works fine?

@fulopdaniel
Copy link
Contributor Author

Did you test the cli and everything if it works fine?

CLI has its own .nvmrc that is still 18. As far as I know the only thing changed here is the github CI actions node version. It's needed for updating fondue to v13.

@ragi96
Copy link
Collaborator

ragi96 commented Sep 1, 2025

Did you test the cli and everything if it works fine?

CLI has its own .nvmrc that is still 18. As far as I know the only thing changed here is the github CI actions node version. It's needed for updating fondue to v13.

Does the CI still work, as it could break, if the workflows are not properly set up (as using on nvmrc what is kind of special imo and workflow may only takes the one you adjusted now)

@fulopdaniel
Copy link
Contributor Author

fulopdaniel commented Sep 1, 2025

Did you test the cli and everything if it works fine?

CLI has its own .nvmrc that is still 18. As far as I know the only thing changed here is the github CI actions node version. It's needed for updating fondue to v13.

Does the CI still work, as it could break, if the workflows are not properly set up (as using on nvmrc what is kind of special imo and workflow may only takes the one you adjusted now)

I mean is there a way to test that locally? :D I think it should be fine, but would love to hear your opinion on how to make sure.

Copy link
Contributor

@marguslant0 marguslant0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2025

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2025

This reverts commit a847a63.
Copy link
Collaborator

@ragi96 ragi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞

@fulopdaniel fulopdaniel merged commit 5c29df0 into main Sep 2, 2025
1 check passed
@fulopdaniel fulopdaniel deleted the chore/bump-nvm branch September 2, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants