feat: add mkcert to use https #1287
Conversation
🦋 Changeset detectedLatest commit: 96a023c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| "prompts": "^2.4.2", | ||
| "vite": "^5.4.19", | ||
| "vite-plugin-externals": "^0.6.2", | ||
| "vite-plugin-mkcert": "^1.17.8", |
There was a problem hiding this comment.
This is generating certificates out of our controls, I would go with self-signed instead.
Here is a list of security issues which happened with mkcert: https://security.snyk.io/package/linux/chainguard%3Alatest/mkcert
There was a problem hiding this comment.
Self signed on the fly (not bundled, it would be another security risk to add it in the CLI bundle) and cached in the user dir so it can be shared with multiple apps (and later blocks/themes) repositories.
-> will use https as default when running dev server for apps.