-
Notifications
You must be signed in to change notification settings - Fork 2
feat: replace metadata with customMetadata #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We should also remove the old metadata in the GQL call and the response interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the deprecated metadata field with a new customMetadata field in the API, aligning both the TypeScript type and the GraphQL fragment with the updated data structure.
- Removed duplicate import of version from package.json
- Replaced metadataValues with customMetadata in FrontifyAsset
- Updated GraphQL fragment to use customMetadata instead of metadataValues
Comments suppressed due to low confidence (1)
src/Api.ts:67
- The customMetadata field is defined as an array in the type (customMetadata: { ... }[]) while the GraphQL fragment treats it as a singular object. Verify that the backend schema and resolvers are intended to support an array and update the GraphQL fragment if necessary.
customMetadata: {
6642552 to
72f485a
Compare
72f485a to
6271cb5
Compare
imoutaharik
approved these changes
Jun 11, 2025
olivereisenhut
added a commit
that referenced
this pull request
Jun 11, 2025
feat: replace metadata with customMetadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
customMetadatafield to replace the deprecatedmetadataValuesfield.