Skip to content

Conversation

@julianiff
Copy link
Contributor

@julianiff julianiff commented Apr 15, 2025

This PR adds the customMetadata field to replace the deprecated metadataValues field.

@julianiff julianiff changed the title chore: update customMetadata chore: update api to have custom Metadata in the finder Apr 15, 2025
@olivereisenhut olivereisenhut changed the title chore: update api to have custom Metadata in the finder feat: replace metadata with customMetadata Apr 15, 2025
@olivereisenhut
Copy link
Contributor

We should also remove the old metadata in the GQL call and the response interface

@julianiff julianiff changed the title feat: replace metadata with customMetadata feat: replace metadata with customMetadata [CU-8698rgh6g] Apr 15, 2025
@julianiff julianiff requested a review from Copilot May 7, 2025 13:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the deprecated metadata field with a new customMetadata field in the API, aligning both the TypeScript type and the GraphQL fragment with the updated data structure.

  • Removed duplicate import of version from package.json
  • Replaced metadataValues with customMetadata in FrontifyAsset
  • Updated GraphQL fragment to use customMetadata instead of metadataValues
Comments suppressed due to low confidence (1)

src/Api.ts:67

  • The customMetadata field is defined as an array in the type (customMetadata: { ... }[]) while the GraphQL fragment treats it as a singular object. Verify that the backend schema and resolvers are intended to support an array and update the GraphQL fragment if necessary.
customMetadata: {

@olivereisenhut olivereisenhut self-assigned this Jun 10, 2025
@olivereisenhut olivereisenhut changed the title feat: replace metadata with customMetadata [CU-8698rgh6g] feat: replace metadata with customMetadata Jun 10, 2025
@olivereisenhut olivereisenhut force-pushed the feat/update-to-custom-metadata branch from 6642552 to 72f485a Compare June 10, 2025 15:09
@olivereisenhut olivereisenhut force-pushed the feat/update-to-custom-metadata branch from 72f485a to 6271cb5 Compare June 10, 2025 15:18
@olivereisenhut olivereisenhut merged commit 4efa5f5 into master Jun 11, 2025
3 checks passed
olivereisenhut added a commit that referenced this pull request Jun 11, 2025
feat: replace metadata with customMetadata
@olivereisenhut olivereisenhut deleted the feat/update-to-custom-metadata branch June 11, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants