Fixed wrong use of styles in DoneButton.js#103
Open
SamiChab wants to merge 1 commit intoFuYaoDe:masterfrom
SamiChab:app-intro-fix
Open
Fixed wrong use of styles in DoneButton.js#103SamiChab wants to merge 1 commit intoFuYaoDe:masterfrom SamiChab:app-intro-fix
SamiChab wants to merge 1 commit intoFuYaoDe:masterfrom
SamiChab:app-intro-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using the custom styles, I found an error:
In file ./components/DoneButton.android.js (line 18), the nextButtonText style was used for the style of the text of the 'Done' button, instead of the controllText style.
<Text style={[styles.nextButtonText, { color: rightTextColor }]}>has to be replaced with
<Text style={[styles.controllText, { color: rightTextColor }]}>