Fixed: next can only be pressed once and not while scrolling; fixes #48#49
Open
aforty wants to merge 1 commit intoFuYaoDe:masterfrom
aforty:fix-next-press-while-scrolling
Open
Fixed: next can only be pressed once and not while scrolling; fixes #48#49aforty wants to merge 1 commit intoFuYaoDe:masterfrom aforty:fix-next-press-while-scrolling
aforty wants to merge 1 commit intoFuYaoDe:masterfrom
aforty:fix-next-press-while-scrolling
Conversation
Author
|
Any movement on this? Not having my app be stuck would be helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #48 describes how the slides would get "stuck" when the next button was pressed too quickly in succession. This was because it would attempt to slide "next" while in a half-state.
This fixes the issue by keeping track of the scrolling position internally as opposed to relying on Swiper's internal isScrolling state which appears often to be wrong or lagging.