Skip to content

Conversation

@kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Jan 13, 2026

Re-enabling tracing, it was problematic in the past because of how we integrated this. Little bit more details:

The WorkerGuard from fuel-telemetry was stored in a static OnceLock in forc-tracing, preventing its Drop implementation from running. This caused, zombie processes remaining after CLI tool execution

Refactored init_tracing_subscriber() to return the WorkerGuard to the caller, enabling proper RAII cleanup when programs exit.

@kayagokalp kayagokalp self-assigned this Jan 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2026

LCOV of commit 9a50d32 during CI #64

Summary coverage rate:
  lines......: 44.2% (1249 of 2823 lines)
  functions..: 34.0% (158 of 465 functions)
  branches...: 28.4% (63 of 222 branches)

Files changed coverage rate: n/a

@kayagokalp kayagokalp changed the title [testing] feat: init fuel-telemetry feat: init fuel-telemetry Jan 19, 2026
@kayagokalp kayagokalp marked this pull request as ready for review January 19, 2026 05:18
@cursor
Copy link

cursor bot commented Jan 19, 2026

PR Summary

Introduces telemetry across forc CLI tools and updates tracing initialization.

  • Adds fuel-telemetry integration in forc-tracing (v0.72.0) with optional telemetry feature enabled by default; re-exports telemetry macros and hides telemetry spans from regular logs
  • Refactors init_tracing_subscriber(...) to return Result<Option<WorkerGuard>>; callers (forc-crypto, forc-wallet, forc-node) now hold and drop the guard to ensure proper shutdown
  • Extends tracing options (disable via env/option, new Stdout writer mode, adjusted log-level application, regex filtering) and updates CHANGELOG
  • Bumps workspace to forc-tracing = 0.72.0 and adds fuel-telemetry dependency; lockfile updates for new/updated crates

Written by Cursor Bugbot for commit 9a50d32. This will update automatically on new commits. Configure here.

@kayagokalp kayagokalp requested a review from zees-dev January 19, 2026 05:18
cursor[bot]

This comment was marked as outdated.

# - Create "forc-tracing-0.71.x" git tag.
version = "0.71.1"
# - Create "forc-tracing-0.72.x" git tag.
version = "0.72.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well update the changelog for forc-tracing at the same time

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

debug_telemetry, error_telemetry, info_telemetry, span_telemetry, trace_telemetry,
warn_telemetry,
};
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry stub macros are dead code due to conflicting cfg guards

Medium Severity

The telemetry module is declared with #[cfg(feature = "telemetry")] in lib.rs, meaning telemetry.rs is only loaded when telemetry is enabled. However, the stub macros inside telemetry.rs are gated with #[cfg(not(feature = "telemetry"))]. These conditions are mutually exclusive, so the disabled_telemetry module and its stub macros can never be compiled. When users disable telemetry and attempt to use these macros, they'll get a confusing "module not found" error instead of the intended clear error message about enabling the telemetry feature.

Additional Locations (1)

Fix in Cursor Fix in Web

@kayagokalp kayagokalp merged commit 1a66135 into main Jan 29, 2026
15 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/telem branch January 29, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants