Create validation in parallel-executor #3031
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces a new `DependencyGraph` module to the `parallel-executor` service and integrates it into the `Validator` implementation. The changes primarily focus on preparing the system for dependency graph management without yet implementing its full functionality. ### Dependency Graph Integration: * **Added `DependencyGraph` to imports**: The `DependencyGraph` type from the `dependency_graph` module was added to the imports in `validator.rs` to enable its usage. * **Introduced `dependency_graph` module**: A new `pub(crate)` module named `dependency_graph` was introduced in the `parallel-executor` service, laying the groundwork for dependency management. * **Initialized `DependencyGraph` in `Validator`**: A `DependencyGraph` instance is now initialized in the `Validator` implementation, using the size hint from the transaction source to determine its initial capacity. However, the graph is not yet actively used in the logic.
…abase changes to verify them
MitchTurner
reviewed
Jun 15, 2025
Comment on lines
+540
to
+559
| #[test] | ||
| fn get_independent_transactions__mixed_dependencies__returns_only_independent() { | ||
| // given | ||
| let mut graph = DependencyGraph::new(2); | ||
| let contract_id = ContractId::from([1u8; 32]); | ||
|
|
||
| // Add transaction without contracts (ready) | ||
| let independent_tx = create_simple_transaction(); | ||
| graph.add_transaction(0, independent_tx); | ||
|
|
||
| // when: Add transaction with contract (ready - first to use contract) | ||
| let dependent_tx = create_transaction_with_contracts(vec![contract_id]); | ||
| graph.add_transaction(1, dependent_tx); | ||
|
|
||
| // then: Only independent transactions should be ready | ||
| let ready = graph.get_ready_transactions(); | ||
| assert_eq!(ready.len(), 2); | ||
| assert!(ready.contains(&0)); | ||
| assert!(ready.contains(&1)); // Both are ready now | ||
| } |
Member
There was a problem hiding this comment.
These tests are all great. Awesome coverage. One little nit I have is there is an inconsistent use of // when and some of these tests the SUT is unclear.
// when should mark the SUT's usage. So in this test I see the SUT is get_independent_transactions but it looks like the SUT might just be get_ready_transactions()?
So I'd expect
let dependent_tx = create_transaction_with_contracts(vec![contract_id]);
graph.add_transaction(1, dependent_tx);
// when
let ready = graph.get_ready_transactions();
// then
assert_eq!(ready.len(), 2);I'm not as worried about the larger sanity tests like dependency_resolution_realistic_scenario below. That seems fine. But there are a few tests that could match the // when and SUT better.
Won't hold up the PR for that though. These tests are already a win.
Member
There was a problem hiding this comment.
i think the function was renamed and the test wasn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TBD