-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Block Aggregator Protobuf API #3100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MitchTurner
wants to merge
140
commits into
master
Choose a base branch
from
chore/protobuf-api-adatper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 126 commits
Commits
Show all changes
140 commits
Select commit
Hold shift + click to select a range
9fb0368
Add naive service with test
MitchTurner d695469
Return a BoxStream instead of just sending over channel
MitchTurner 8384238
Cleanup
MitchTurner db993bf
Add failing test
MitchTurner 17ac53c
Add test for receiving new block
MitchTurner 77d64ef
Cleanup
MitchTurner ad951b9
Lint
MitchTurner 267ce07
Add query for current height to allow checking the progress
MitchTurner 78f1ee0
Remove commented code
MitchTurner 90867f8
Update CHANGELOG
MitchTurner f6d2fdb
Fix privacy of constructor
MitchTurner e612ea2
Improve tests, fix flake
MitchTurner 489e74c
Remove commented code
MitchTurner 56f4eb0
Remove unnecessary task spawn
MitchTurner 7216d38
Update crates/services/block_aggregator_api/src/lib.rs
MitchTurner 5119ab9
Update crates/services/block_aggregator_api/Cargo.toml
MitchTurner dc4f1aa
use futures instead of future-utils
MitchTurner 720694a
Fix Debug impl and only use in test
MitchTurner e1a7305
Add assoc type for block response to allow for a variety of types
MitchTurner 51b7268
Lin toml
MitchTurner 389c46b
Add example block range response type
MitchTurner a12da43
Add documentation
MitchTurner 541b71b
Re-add debug impl for everyone
MitchTurner 5236bee
WIP add bare adapter
MitchTurner 146812e
Fix compilation
MitchTurner 995c6e1
Add failing test
MitchTurner cedacfc
Remove commented code
MitchTurner 930b465
WIP
MitchTurner 71b5d12
Use `BlockHeight` instead of `u64`
MitchTurner b9c6ead
Merge branch 'chore/add-block-aggregator-service' into chore/block-ag…
MitchTurner 325de73
Add failing test
MitchTurner ced1c10
Wip add get_block_range test
MitchTurner fce4c3c
Add a custom stream that gets the job done. Maybe not performant
MitchTurner 9540a5f
Merge branch 'master' into chore/add-block-aggregator-service
MitchTurner 8c56749
Merge branch 'chore/add-block-aggregator-service' into chore/block-ag…
MitchTurner eb280c7
Use view for stream of db data
MitchTurner 8d178e1
Cleanup
MitchTurner 571691f
Add changelog, spellcheck, lint
MitchTurner 5797130
Basic
MitchTurner 119af9b
Appease Clippy-sama
MitchTurner b738793
Remove commented code
MitchTurner 3bd552b
Merge branch 'chore/block-aggregator-db-adapter' into chore/add-apdap…
MitchTurner 6649ac6
Add tests for get_current_height indirectly
MitchTurner 0bb38ef
Merge branch 'chore/block-aggregator-db-adapter' into chore/add-apdap…
MitchTurner 010e111
Remove unnecessary clone
MitchTurner 8e0619b
Merge branch 'chore/block-aggregator-db-adapter' into chore/add-apdap…
MitchTurner dab98e2
Add block subscription code
MitchTurner 358a242
Appease Clippy-sama
MitchTurner e393cc4
Merge branch 'chore/block-aggregator-db-adapter' into chore/add-apdap…
MitchTurner 0b7aaa5
Fix imports
MitchTurner 0a17d3c
Update CHANGELOG
MitchTurner d0f2c81
fmt
MitchTurner 95a38fc
Add old block test
MitchTurner 81194d4
Add drain method to source
MitchTurner 00ce90b
Merge branch 'chore/add-block-aggregator-service' into chore/block-ag…
MitchTurner 3b2931b
Merge branch 'chore/block-aggregator-db-adapter' into chore/add-apdap…
MitchTurner 15b3733
Add doc
MitchTurner 17030c0
Merge branch 'chore/add-block-aggregator-service' into chore/block-ag…
MitchTurner 6c690a9
Merge branch 'chore/block-aggregator-db-adapter' into chore/add-apdap…
MitchTurner 41343c2
Remove empty mod
MitchTurner 6a16f99
Merge remote-tracking branch 'origin' into chore/block-aggregator-db-…
MitchTurner db77caf
Merge branch 'chore/block-aggregator-db-adapter' into chore/add-apdap…
MitchTurner 2fa9b2c
WIP add new adapter
MitchTurner 53b2b18
Get test passing
MitchTurner 2d44731
Refactor
MitchTurner e9a04b5
Add db to task generics
MitchTurner 67e63af
Add more for dbs
MitchTurner ba51463
Get basic db sync test working
MitchTurner 145b94d
Include tx in db
MitchTurner 6884644
Update CHANGELOG
MitchTurner c5bd39c
Refactor
MitchTurner 7995ff4
Refactor into two services
MitchTurner 86db658
lint
MitchTurner 7143929
Note some questions about the intended behavior
MitchTurner a59e27e
Fix test to look for correct variant
MitchTurner 1c9a129
Merge branch 'master' into chore/block-aggregator-db-adapter
xgreenx 98f7d64
Merge branch 'chore/block-aggregator-db-adapter' into chore/add-apdap…
MitchTurner 8c32bd6
Merge branch 'master' into chore/block-aggregator-db-adapter
MitchTurner 1f1a4cc
Merge branch 'chore/block-aggregator-db-adapter' into chore/add-apdap…
MitchTurner 06d3428
Add warning trace instead of just comment
MitchTurner 9ed34e4
Merge branch 'chore/block-aggregator-db-adapter' into chore/add-apdap…
MitchTurner 7af852b
Update crates/services/block_aggregator_api/src/lib.rs
MitchTurner a813c34
Hide test methods, fix trace message
MitchTurner b1273d6
Merge branch 'chore/add-apdapter-for-block-aggregator-source' into ch…
MitchTurner d0f50c6
Rename tasks, remove feature from deps
MitchTurner 89ad266
Account for `NewBlock` type
MitchTurner 231485c
Increase timeout on failing test
MitchTurner 755997c
Merge branch 'chore/block-aggregator-db-adapter' into chore/add-apdap…
MitchTurner c8975fb
Merge branch 'chore/add-apdapter-for-block-aggregator-source' into ch…
MitchTurner 2910881
Fix spelling
MitchTurner fff0c74
Add new test for taking into account importer height
MitchTurner a9b3851
Remove todos
MitchTurner bdf8f33
Refactor and cover cases better
MitchTurner b2a67a7
Cleanup
MitchTurner eeeccb7
Appease Clippy-sama
MitchTurner 0ce096e
Merge branch 'master' into chore/add-apdapter-for-block-aggregator-so…
MitchTurner 5c43e86
Merge branch 'chore/add-apdapter-for-block-aggregator-source' into ch…
MitchTurner 8c30b6b
remove comment
MitchTurner 74e9230
Add error handling for broken tasks
MitchTurner 13a8901
Cleanup
MitchTurner ceede2a
Create protobuf server and client and implement first endpoint
MitchTurner 3e47823
Lint, update changelog
MitchTurner d808cf1
include `protoc` in CI image
MitchTurner 7f01759
Start adding range stream
MitchTurner aad009a
Add failing test
MitchTurner d463547
Add stream of blocks
MitchTurner 1519a28
Add test for new block stream
MitchTurner 9d68fc3
Lint toml
MitchTurner 0315228
Remove comments
MitchTurner 7c63d40
Fix compilation
MitchTurner 918c156
Merge branch 'master' into chore/add-apdapter-for-block-aggregator-so…
MitchTurner a1af5a7
Remove comment, rename fn
MitchTurner b110538
Merge branch 'chore/add-apdapter-for-block-aggregator-source' into ch…
MitchTurner 2d71835
Merge branch 'chore/block-source-for-aggregator' into chore/protobuf-…
MitchTurner 505ce6c
Merge branch 'master' into chore/block-source-for-aggregator
MitchTurner 3d66f8a
Merge branch 'chore/block-source-for-aggregator' into chore/protobuf-…
MitchTurner 9636204
fmt
MitchTurner 596daf2
Merge branch 'chore/block-source-for-aggregator' into chore/protobuf-…
MitchTurner dab0ef2
Revert mistake from merge
MitchTurner 3b917ba
Remove `mut`
MitchTurner 01f6f98
Merge branch 'chore/block-source-for-aggregator' into chore/protobuf-…
MitchTurner 4454103
Merge branch 'master' into chore/protobuf-api-adatper
MitchTurner 2e723bb
Merge branch 'master' into chore/protobuf-api-adatper
MitchTurner 47a89db
Add recommended changes from previous PR
MitchTurner c61cbae
Fix spelling
MitchTurner 8bb41cf
MAke proto block response an enum
MitchTurner ad652dd
Update crates/services/block_aggregator_api/src/api/protobuf_adapter.rs
MitchTurner a0d99f2
include inner error in API error message
MitchTurner d821f9c
Merge branch 'master' into chore/protobuf-api-adatper
MitchTurner db15acc
Merge remote-tracking branch 'origin/master' into chore/protobuf-api-…
MitchTurner 55b3686
Integrate Block Aggregator (#3101)
MitchTurner a7c3e28
Merge branch 'master' into chore/protobuf-api-adatper
MitchTurner b2b023b
Fix cargo lock
MitchTurner ab29ec6
Ignore rustsec with tracking issue
MitchTurner 9dbd0e4
Merge branch 'chore/rustsec-2025-0118' into chore/protobuf-api-adatper
MitchTurner 412be8a
Fix spellcheck, update changelog
MitchTurner 3db8c2f
Merge branch 'chore/rustsec-2025-0118' into chore/protobuf-api-adatper
MitchTurner 0ae1f71
Merge branch 'master' into chore/protobuf-api-adatper
MitchTurner 7b49d6d
Merge branch 'master' into chore/protobuf-api-adatper
MitchTurner 0da8556
Merge branch 'master' into chore/protobuf-api-adatper
MitchTurner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add protobuf api for querying the block aggregator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to not require additional dependency? For example, maybe
toniccould use Rust-based implementation of the protobuf?If not, I think we should follow @rymnc's suggestion and move Protobuf definition into a separate repository which will publish a Rust crate which we can use later in
fuel-core, t avoid additional dependency for SDK and SwayThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. That makes sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove dependency from
protocbefore we merge this change to themaster=)