Skip to content

Conversation

@Voxelot
Copy link
Member

@Voxelot Voxelot commented Nov 3, 2025

This pull request updates the CI/CD workflow configurations to use newer GitHub Actions versions and modernize the runner infrastructure around warpbuild. It also refactors the Docker image build and publish process to streamline jobs and improve caching and platform support. The changes help ensure compatibility, improve build performance, and simplify maintenance.

Workflow runner and actions modernization:

  • Updated all workflow jobs to use newer runners (ubuntu-latest or warp-ubuntu-2404-x64-4x) instead of buildjet-* runners, improving reliability and future compatibility. (.github/workflows/ci.yml: [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]
  • Upgraded all uses of actions/checkout to version 5 across workflows for improved performance and security. (.github/workflows/ci.yml: [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]; .github/workflows/create_version.yml: [11]; .github/workflows/delete-test-env.yml: [12]; .github/workflows/deploy-test-env.yml: [13]; .github/workflows/dependencies.yml: [14] [15]; .github/workflows/docker-images.yml: [16] [17]

Docker workflow refactor and improvements:

  • Refactored Docker image build and publish jobs: merged build and publish steps, switched to Warpbuilds/build-push-action, and added multi-platform support (linux/amd64,linux/arm64). Removed custom cache and manifest logic for simplicity. (.github/workflows/docker-images.yml: [1] [2] [3] [4]
  • Updated artifact upload/download actions to latest versions (actions/upload-artifact@v5, actions/download-artifact@v6) for dependency and build logs. (.github/workflows/dependencies.yml: [1] [2]

Workflow triggers and permissions:

These updates make use of warpbuilds improved caching infrastructure and better runner cost / performance / security.


Note

Migrates workflows to warp/ubuntu runners and checkout v5, and refactors Docker builds to Warpbuilds with multi-arch and PR triggers.

  • CI Workflows

    • Switch runners from buildjet-* to ubuntu-latest or warp-ubuntu-* across jobs.
    • Upgrade to actions/checkout@v5 everywhere; update artifact actions to upload-artifact@v5 and download-artifact@v6.
    • Replace buildjet/cache with WarpBuilds/rust-cache@v2; keep mold setup.
    • Adjust cargo-verifications, publish-crates(-check), and cargo-test-kms to warp runners; minor matrix/env tweaks.
    • Release binaries matrix now uses warp Linux runners; Docker login steps gated by matrix.job.target.
    • Minor toolchain/env bumps in ci.yml (e.g., RUST_VERSION_FMT/COV).
  • Docker Images

    • Collapse build/publish into publish-docker-images; use Warpbuilds/build-push-action@v6 with multi-platform (linux/amd64,linux/arm64).
    • Add pull_request trigger; keep GHCR/DockerHub/ECR logins; use docker/metadata-action@v5 for tags.
    • Mirror pattern for profiling and e2e-client images; standardize on warp runners.
    • deploy-eph-env depends on publish-docker-images and runs on warp.
  • Other Workflows

    • Update checkout to v5 in create_version, delete/deploy-test-env, e2e-test-beta4-dev, nightly-*, publish-codecov, releasy, spellcheck, and update_readme_versions.
    • publish-codecov runs on warp and retains llvm-cov publishing to codecov-pages.

Written by Cursor Bugbot for commit 87ff1aa. This will update automatically on new commits. Configure here.

@Voxelot Voxelot marked this pull request as draft November 3, 2025 23:18
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Registry Login Breaks for Cross-Arch Builds

The Docker registry login condition changed from checking the OS to checking for the aarch64-unknown-linux-gnu target. This causes the x86_64 Linux job to no longer log in, but it still requires registry access for its cross-compilation environment, leading to authentication failures.

Fix in Cursor Fix in Web

@Voxelot Voxelot added the no changelog Skip the CI check of the changelog modification label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog Skip the CI check of the changelog modification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants