Skip to content

Conversation

@grandima
Copy link

@grandima grandima commented May 16, 2025

Closes #1591

Release notes

In this release, we:

  • Added a possibility to configure max_fee_estimation_tolerance in CallHandler, TransactionTuner and Executable

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Note

Adds a configurable max_fee_estimation_tolerance across call handlers, transaction builders, and loader blob uploads, with tests.

  • SDK - Calls:
    • CallHandler:
      • Add field max_fee_estimation_tolerance with builder with_max_fee_estimation_tolerance(...).
      • Propagate tolerance into transaction_builder_with_parameters and builder creation.
    • TransactionTuner (trait and impls):
      • Extend transaction_builder(...) signature to accept max_fee_estimation_tolerance: f32.
      • ScriptCall/ContractCall/Vec<ContractCall> pass tolerance to ScriptTransactionBuilder.with_max_fee_estimation_tolerance(...).
    • calls/utils.rs:
      • transaction_builder_from_contract_calls(...) now takes tolerance and forwards it to the builder.
  • SDK - Executable:
    • Add upload_blob_with_tolerance(account, max_fee_estimation_tolerance); upload_blob delegates to it.
    • Use tolerance in BlobTransactionBuilder.with_max_fee_estimation_tolerance(...).
  • Tests:
    • Add test_max_fee_estimation_tolerance in e2e/tests/contracts.rs validating default and custom tolerances.

Written by Cursor Bugbot for commit e0c5d84. This will update automatically on new commits. Configure here.

@grandima grandima requested a review from a team as a code owner May 16, 2025 16:57
@fuel-cla-bot
Copy link

fuel-cla-bot bot commented May 16, 2025

Thanks for the contribution! Before we can merge this, we need @grandima to sign the Fuel Labs Contributor License Agreement.

@grandima grandima force-pushed the 1591-max-estimation branch from 323c2d7 to e0c5d84 Compare October 31, 2025 13:21
@grandima
Copy link
Author

@segfault-magnet please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make max estimation fee tolerance configurable in call handlers

1 participant