Skip to content

Conversation

@vaivaswatha
Copy link
Contributor

@vaivaswatha vaivaswatha commented Nov 11, 2025

Closes #4517


Note

Make IR value names deterministic in the printer and update tests, expectations, and round-trip checks to match the new stable naming scheme.

  • IR Printer:
    • Deterministic value naming: switch default names from sequential v<idx> to stable v<slot_key> (v\d+v\d+), importing slotmap::Key.
  • Optimizer Tests:
    • Adjust constant folding expectations (omit temp name in const lines) and fixed expected value names in assertions.
  • Test Suite:
    • Update all IR filecheck regexes and snapshots to new value-name pattern.
    • Strengthen IR (de)serialization test to round-trip twice for stability.
    • Minor test regex tweaks (e.g., panic regex, mem2reg/serialize expectations).

Written by Cursor Bugbot for commit 5b4f77a. This will update automatically on new commits. Configure here.

@vaivaswatha vaivaswatha self-assigned this Nov 11, 2025
@vaivaswatha vaivaswatha marked this pull request as ready for review November 12, 2025 07:44
@vaivaswatha vaivaswatha requested a review from a team as a code owner November 12, 2025 07:44
@vaivaswatha vaivaswatha enabled auto-merge (squash) November 13, 2025 07:13
@vaivaswatha vaivaswatha requested a review from a team November 13, 2025 11:22
xunilrj
xunilrj previously approved these changes Nov 13, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 7

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@vaivaswatha vaivaswatha requested review from a team and xunilrj November 19, 2025 06:19
@vaivaswatha vaivaswatha merged commit 0682209 into master Nov 24, 2025
46 checks passed
@vaivaswatha vaivaswatha deleted the vaivaswatha/irval_printing branch November 24, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support single instructions and custom value names in IR printer

4 participants