Conversation
essential-randomness
force-pushed
the
zod
branch
from
cd93e15 to
f39a98c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr: the astro ao3 loader needs zod schemas for content collections, so here they are!
The less tl;dr is we wrote these manually until now, but I wanted to see whether we could generate them from TS types. The answer is yes, but we need the original source code...which leads us to this PR.
Overall, Zod is marked as an external peer dependency, so the bundle size increase is tiny. We could make a completely different package, but I don't think it's worth it.