Skip to content

fix: resolve Quote struct type mismatch and update tests

237f487
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix failing tests from recent commit #103

fix: resolve Quote struct type mismatch and update tests
237f487
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Nov 8, 2025 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.91.0 (f8297e351 2025-10-28)
  • cargo 1.91.0 (ea2d97820 2025-10-10)
  • clippy 0.1.91 (f8297e351a 2025-10-28)

Annotations

Check warning on line 157 in functions/create-issue/src/template.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (9/7)

warning: this function has too many arguments (9/7)
   --> functions/create-issue/src/template.rs:147:5
    |
147 | /     pub fn render_newsletter(
148 | |         &self,
149 | |         issue_number: u32,
150 | |         quote: &Quote,
...   |
156 | |         sponsor: Option<&Sponsor>,
157 | |     ) -> Result<String> {
    | |_______________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 31 in functions/create-issue/src/datetime_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of an assign operation

warning: manual implementation of an assign operation
  --> functions/create-issue/src/datetime_utils.rs:31:9
   |
31 |         target = target + Duration::days(1);
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target += Duration::days(1)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#assign_op_pattern
   = note: `#[warn(clippy::assign_op_pattern)]` on by default

Check warning on line 27 in functions/fetch-quote/src/models.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `url` is never read

warning: field `url` is never read
  --> functions/fetch-quote/src/models.rs:27:9
   |
23 | pub struct InputQuote {
   |            ---------- field in this struct
...
27 |     pub url: String,
   |         ^^^

Check warning on line 15 in functions/fetch-quote/src/models.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `id` and `url` are never read

warning: fields `id` and `url` are never read
  --> functions/fetch-quote/src/models.rs:15:9
   |
14 | pub struct Author {
   |            ------ fields in this struct
15 |     pub id: String,
   |         ^^
...
19 |     pub url: String,
   |         ^^^