Skip to content

Andre Moon #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Andre Moon #2

wants to merge 6 commits into from

Conversation

MoonMan120
Copy link

No description provided.

Copy link

@monterojavier monterojavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to have your html files structured correctly 👌

Comment on lines +34 to +43
</body>
<footer class="F1">
<a target="_blank" href="https://github.com/MoonMan120">
<img class="git" src="github-mark-white.png" alt="white github link" />
</a>
<a target="_blank" href="https://www.linkedin.com/in/andre-moon-148813185/">
<img class="linked" src="InBug-White.png" alt="linkedin logo" />
</a>
</body>
</footer>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looks like you added a extra closing body tag
  • And you have the closing footer outside the body. You want to keep all the content inside the body

<img class="linked" src="InBug-White.png" alt="linkedin logo" />
</a>
</footer>
</html>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the html is the very last element in the file

Comment on lines +23 to +41
<footer class="F1">
<a target="_blank" href="https://github.com/MoonMan120">
<img class="git" src="github-mark-white.png" alt="white github link" />
</a>
<a target="_blank" href="https://www.linkedin.com/in/andre-moon-148813185/">
<img class="linked" src="InBug-White.png" alt="linkedin logo" />
</a>
</footer>
</html>

<section id="forms">
<form action="/url" method="GET">
<p>Enter name below:</p>
<input type="text">
<p>Email:</p>
<input type="text"> <br>
<button>submit</button>
</form>
</section>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want all the content that is going to show on the page to be inside of the body tag

Take look at how this is written:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants