Skip to content

Conversation

@NotHyper-474
Copy link
Contributor

@NotHyper-474 NotHyper-474 commented May 16, 2025

Associated PR

FunkinCrew/lime#12

Linked Issues

N/A

Description

This is part of my work on implementing multiple audio file formats (like MP3, FLAC and some others), which required changing this class to also accommodate for 32bit audio.
Just two things to consider:

  • It expects all audio to be either signed 8 bit, signed 16 bit, or 32 bit float (could've been 32 bit int too but limitations on the current OpenAL-Soft version prevented that). I can probably adjust the Lime PR to also allow for detecting the sign though.
  • The game doesn't seem to be actually able to decode 32 bit audio to actual 32 bit, the OGG decoder seems to only decode to 16 bits at most, and while WAV can there's no handling for that bit per sample on NativeAudioSource. To put it simple, this PR only really makes sense if merged alongside the Lime one.

Screenshots/Videos

(Note: Being able to load MP3 audio is not part of this PR)

heatwaves.mp4

There is also no significant difference between waveforms!

8 bit 16 bit 32 bit Float
8bit 16bit 32bit

@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels May 16, 2025
@NotHyper-474 NotHyper-474 force-pushed the waveformdataparser-enhancements branch from be3564b to 3a05505 Compare May 16, 2025 17:25
@github-actions github-actions bot added the size: medium A medium pull request with 100 or fewer changes. label May 16, 2025
@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. labels May 16, 2025
@NotHyper-474 NotHyper-474 force-pushed the waveformdataparser-enhancements branch from bdfc924 to e33c19e Compare May 16, 2025 20:57
@NotHyper-474 NotHyper-474 marked this pull request as ready for review May 16, 2025 20:58
@NotHyper-474 NotHyper-474 force-pushed the waveformdataparser-enhancements branch from aa4129a to 93d7118 Compare May 19, 2025 16:46
@NotHyper-474 NotHyper-474 marked this pull request as draft June 12, 2025 21:44
@NotHyper-474 NotHyper-474 force-pushed the waveformdataparser-enhancements branch 2 times, most recently from c62755d to 8e2eff5 Compare June 20, 2025 21:31
@NotHyper-474 NotHyper-474 force-pushed the waveformdataparser-enhancements branch from 8e2eff5 to e7c1e48 Compare June 30, 2025 03:36
@github-actions github-actions bot added size: large A large pull request with more than 100 changes. and removed size: medium A medium pull request with 100 or fewer changes. labels Jun 30, 2025
@NotHyper-474 NotHyper-474 force-pushed the waveformdataparser-enhancements branch from e7c1e48 to caf636f Compare July 22, 2025 19:39
@github-actions github-actions bot added size: medium A medium pull request with 100 or fewer changes. and removed size: large A large pull request with more than 100 changes. labels Jul 22, 2025
@NotHyper-474 NotHyper-474 force-pushed the waveformdataparser-enhancements branch from caf636f to b93821d Compare July 22, 2025 19:52
@NotHyper-474 NotHyper-474 force-pushed the waveformdataparser-enhancements branch from b93821d to 6732121 Compare July 30, 2025 03:14
@NotHyper-474 NotHyper-474 force-pushed the waveformdataparser-enhancements branch from 6732121 to 64c5433 Compare August 3, 2025 12:31
@NotHyper-474 NotHyper-474 force-pushed the waveformdataparser-enhancements branch from 64c5433 to e3a3c2b Compare September 3, 2025 21:48
@Hundrec Hundrec force-pushed the waveformdataparser-enhancements branch from e3a3c2b to 4fda378 Compare September 14, 2025 15:22
@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels Sep 14, 2025
@NotHyper-474 NotHyper-474 force-pushed the waveformdataparser-enhancements branch from 4fda378 to ff41920 Compare January 14, 2026 04:01
@NotHyper-474
Copy link
Contributor Author

I drafted this cuz I wanted to get it working on web but meh, whatever

@NotHyper-474 NotHyper-474 marked this pull request as ready for review January 14, 2026 04:01
@Hundrec Hundrec added status: pending triage Awaiting review. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.

Development

Successfully merging this pull request may close these issues.

4 participants