-
Notifications
You must be signed in to change notification settings - Fork 2.5k
WaveformDataParser: 32bit float audio support #5104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NotHyper-474
wants to merge
1
commit into
FunkinCrew:develop
Choose a base branch
from
NotHyper-474:waveformdataparser-enhancements
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WaveformDataParser: 32bit float audio support #5104
NotHyper-474
wants to merge
1
commit into
FunkinCrew:develop
from
NotHyper-474:waveformdataparser-enhancements
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be3564b to
3a05505
Compare
bdfc924 to
e33c19e
Compare
lunacynne
approved these changes
May 17, 2025
aa4129a to
93d7118
Compare
TechnikTil
approved these changes
Jun 2, 2025
c62755d to
8e2eff5
Compare
8e2eff5 to
e7c1e48
Compare
e7c1e48 to
caf636f
Compare
caf636f to
b93821d
Compare
b93821d to
6732121
Compare
6732121 to
64c5433
Compare
64c5433 to
e3a3c2b
Compare
e3a3c2b to
4fda378
Compare
4fda378 to
ff41920
Compare
Contributor
Author
|
I drafted this cuz I wanted to get it working on web but meh, whatever |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: haxe
PR modifies game code.
size: medium
A medium pull request with 100 or fewer changes.
status: pending triage
Awaiting review.
type: enhancement
Involves an enhancement or new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated PR
FunkinCrew/lime#12
Linked Issues
N/A
Description
This is part of my work on implementing multiple audio file formats (like MP3, FLAC and some others), which required changing this class to also accommodate for 32bit audio.
Just two things to consider:
NativeAudioSource. To put it simple, this PR only really makes sense if merged alongside the Lime one.Screenshots/Videos
(Note: Being able to load MP3 audio is not part of this PR)
heatwaves.mp4
There is also no significant difference between waveforms!