Skip to content

Conversation

@TerraFail451
Copy link

@TerraFail451 TerraFail451 commented Dec 17, 2025

Linked Issues

Description

This was originally just going to be a repeat of #5229 because the PR was stale, but then I had the idea to make the death counter singular when you have one death.

This PR makes it so that if the death count is at one, the death count is singular. If it's at any other value, its plural.

This PR also allows for player characters to be given unique deaths names on the pause menu that match up with their game over animations. This is done through the deathName and deathNameSingular variables in the player's .json file. I provide those files in the funkin.assets PR (FunkinCrew/funkin.assets#316).
I chose the dual variable approach because it's way easier than trying to account for words that end in "s" in the singular form (like loss --> losses) and irregular plurals (like goose --> geese, mouse --> mice, or sheep --> sheep).

btw the default deathName is Deaths and the default deathNameSingular is Death. i just gave Pico the defaults because I couldnt think of anything better and he does in fact die so it works. but if you can think of anything better its just two lines in his .json file that you have to change.

Screenshots/Videos

Boyfriend with 0 Blue Balls

Boyfriend with 0 Blue Balls

Boyfriend with 1 Blue Ball

Boyfriend with 1 Blue Ball

Boyfriend with 2 Blue Balls

Boyfriend with 2 Blue Balls

Pico with 0 Deaths

Pico with 0 Deaths

Pico with 1 Death

Pico with 1 Death

Pico with 2 Deaths

Pico with 2 Deaths

@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. and removed size: medium A medium pull request with 100 or fewer changes. labels Dec 17, 2025
@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. topic: polish Involves minor polish to the UI or gameplay. size: medium A medium pull request with 100 or fewer changes. labels Dec 18, 2025
@TerraFail451 TerraFail451 changed the title Improve death counter in pause menu [Enhancement] Improve death counter in pause menu Dec 18, 2025
@TerraFail451 TerraFail451 marked this pull request as ready for review December 18, 2025 22:04
@VirtuGuy
Copy link
Contributor

absolute cinema

@Hundrec Hundrec added the topic: changes assets Modifies the assets submodule, or has an associated pull request in the funkin.assets repository. label Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: changes assets Modifies the assets submodule, or has an associated pull request in the funkin.assets repository. topic: polish Involves minor polish to the UI or gameplay. type: enhancement Involves an enhancement or new feature.

Development

Successfully merging this pull request may close these issues.

Enhancement: change pause menu blue balls text depending on the playable character

3 participants