[BUGFIX] Prevent Importing non-Osu!Mania beatmaps #6624
+34
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
Member
|
Looks promising, will take a look later. |
Hundrec
added
size: large
Hundrec
changed the title
FuroYT
force-pushed
the
feat/osu-mania-import
branch
from
0b2feb0 to
4fce2c9
Compare
github-actions
bot
added
size: medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the merge of #6155 i realized that the game doesnt restrict you from importing non mania osu! beatmaps so this pull request fixes that behavior
this pr also cleans the import process code so its also kind of a chore for that part