Skip to content

[ENHANCEMENT] Add autosync between save files through Newgrounds - #7892

Open
MrMadera wants to merge 2 commits into
FunkinCrew:preview/public-playtestfrom
MrMadera:feat/ng-save-files-auto-sync
Open

[ENHANCEMENT] Add autosync between save files through Newgrounds#7892
MrMadera wants to merge 2 commits into
FunkinCrew:preview/public-playtestfrom
MrMadera:feat/ng-save-files-auto-sync

Conversation

@MrMadera

@MrMadera MrMadera commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Linked Issues

#7318

Description

This PR adds an autosync preference that when enabled, connects to Newgrounds to automatically download/upload save files and maintain them up to date.

Screenshots/Videos

cannot test myself since it is a newgrounds feature

@github-actions github-actions Bot added size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. pr: haxe PR modifies game code. labels Aug 8, 2026
@NotHyper-474 NotHyper-474 added type: enhancement Involves an enhancement or new feature. topic: save data Related to storage and management of user save data. labels Aug 8, 2026
@MrMadera
MrMadera force-pushed the feat/ng-save-files-auto-sync branch from d77d9f2 to c2517bb Compare August 8, 2026 18:40
@MrMadera
MrMadera changed the base branch from develop to preview/public-playtest August 11, 2026 07:22
@MrMadera
MrMadera force-pushed the feat/ng-save-files-auto-sync branch from c2517bb to 151f54a Compare August 11, 2026 07:32
@MrMadera
Added autosync save files through Newgrounds
96d13c9 
Created method to save files to newgrounds if autosync is enabled

Saving to Newgrounds automatically if autosync is enabled

Space on condition

Saving song scores

Since slots load async, wait until it finishes to autosync

Better way to check outdated data

Ensure save slot is not null

Used thx to do content comparasion

Update NewgroundsClient.hx

Ok, this was a funny one

Syntax fix + check if file is empty too

Introduce trace into function since saving save files is async too

I forgot this was an error too lol

Sorry documentation, I deleted you somehow during rebase

Left this as it used to be on preview/public-playtest

Oh man this is going to cry :super_sob:
@MrMadera
MrMadera force-pushed the feat/ng-save-files-auto-sync branch from 56b6049 to 96d13c9 Compare August 11, 2026 07:39
@EliteMasterEric

EliteMasterEric commented Aug 19, 2026

Copy link
Copy Markdown
Member

This is kinda scary, what happens if the option is enabled but you aren't logged into Newgrounds?

I'm just frightened of an edge case giving you a blank Save and then deleting your game data...

@MrMadera

MrMadera commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Since I couldn't test this while I was coding it, I tried to cancel operations if save slots were null or empty (especially on autoSyncSavesFromNewgrounds). Anyway, that check can of course be added too for extra safety I guess. (I will also delete an extra call I made to autoSyncSavesFromNewgrounds when InitState is created, I think it's enough only checking when login is successful)

@AbnormalPoof
AbnormalPoof force-pushed the preview/public-playtest branch from 401b06b to 2e7f104 Compare August 20, 2026 03:25
@Hundrec
Hundrec force-pushed the preview/public-playtest branch from fff3525 to 25ad66b Compare August 21, 2026 09:53
TechnikTil
TechnikTil approved these changes Aug 22, 2026
View reviewed changes

@TechnikTil TechnikTil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the "Newgrounds Save Slot Guy", I approve of this PR.

Funnily enough, I wanted to do this originally. I eventually decided not to do it though so I wouldn't clutter up the PR. (also laziness but shhhh)

@Hundrec Hundrec linked an issue Aug 22, 2026 that may be closed by this pull request
Enhancement: Newgrounds autosync option between PC and mobile save files #7318
Open
3 tasks
@MrMadera

MrMadera commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

Oh glad to get the approval of the Newgrounds Save Slot Guy :))

@Hundrec
Hundrec force-pushed the preview/public-playtest branch from 3f2fe37 to a1fa227 Compare September 1, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@TechnikTil TechnikTil TechnikTil approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. topic: save data Related to storage and management of user save data. type: enhancement Involves an enhancement or new feature.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: Newgrounds autosync option between PC and mobile save files

4 participants

@MrMadera @EliteMasterEric @TechnikTil @NotHyper-474