Skip to content

[BUGFIX] Change all ERegs to be multi-thread safe - #8069

Merged
Hundrec merged 1 commit into
FunkinCrew:preview/public-playtestfrom
nykwono:thread-safety-eregs
Sep 2, 2026
Merged

[BUGFIX] Change all ERegs to be multi-thread safe#8069
Hundrec merged 1 commit into
FunkinCrew:preview/public-playtestfrom
nykwono:thread-safety-eregs

Conversation

@nykwono

@nykwono nykwono commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Turns out there's a bunch of static ERegs used in the game. This, if not careful enough will cause multi-threads to hang due to ERegs not being safe, so this PR makes (most) ERegs localized to help with thread safety.

PR goes with this also #1

@github-actions github-actions Bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels Sep 1, 2026
@NotHyper-474 NotHyper-474 added the type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression label Sep 1, 2026
@NotHyper-474 NotHyper-474 added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Sep 2, 2026
@NotHyper-474 NotHyper-474 added this to the Mod Menu milestone Sep 2, 2026

@Hundrec Hundrec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hell yeah!

@Hundrec
Hundrec merged commit 2d1183e into FunkinCrew:preview/public-playtest Sep 2, 2026
6 checks passed
@nykwono
nykwono deleted the thread-safety-eregs branch September 2, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression

Development

Successfully merging this pull request may close these issues.

3 participants