Skip to content

[CRASHFIX] Fix Stage Editor crashing on exit when unsaved changes exist - #8082

Merged
Hundrec merged 1 commit into
FunkinCrew:preview/public-playtestfrom
kiryvajiravuth:wildcard
Sep 7, 2026
Merged

[CRASHFIX] Fix Stage Editor crashing on exit when unsaved changes exist#8082
Hundrec merged 1 commit into
FunkinCrew:preview/public-playtestfrom
kiryvajiravuth:wildcard

Conversation

@kiryvajiravuth

Copy link
Copy Markdown
Contributor

Linked Issues

Closes #8077

Description

FileFilter.extension returns "*.fnfs" (with a wildcard * meant for file dialog filtering). Two places in StageEditorState were using it as a literal filename extension, producing invalid paths like stage-editor-Limo Ride-...-.*.fnfs which crash on file write.

Fixed by replacing FileUtil.FILE_FILTER_FNFS.extension with the literal string '.fnfs' in backup filename construction and backup file matching.

Screenshots/Videos

Before :

huss.mp4

After :

valley.mp4

@github-actions github-actions Bot added status: pending triage Awaiting review. size: tiny A tiny pull request with 4 or fewer changes. pr: haxe PR modifies game code. labels Sep 5, 2026
@kiryvajiravuth
kiryvajiravuth force-pushed the wildcard branch 2 times, most recently from 73b7a41 to 3025f82 Compare September 5, 2026 10:09
@kiryvajiravuth
kiryvajiravuth marked this pull request as ready for review September 5, 2026 10:09
@kiryvajiravuth
kiryvajiravuth marked this pull request as draft September 5, 2026 10:14
@kiryvajiravuth
kiryvajiravuth marked this pull request as ready for review September 5, 2026 10:15
@NotHyper-474 NotHyper-474 added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression topic: stage editor Related to the operation of the Stage Editor. labels Sep 5, 2026
@Hundrec
Hundrec self-requested a review September 6, 2026 03:15

@Hundrec Hundrec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, one step closer to fixing these Stage Editor crashes!

@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Sep 7, 2026
@Hundrec Hundrec added this to the 0.9.0 - Week 8 milestone Sep 7, 2026
@Hundrec
Hundrec merged commit c8df830 into FunkinCrew:preview/public-playtest Sep 7, 2026
6 checks passed
@kiryvajiravuth
kiryvajiravuth deleted the wildcard branch September 7, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: stage editor Related to the operation of the Stage Editor. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression

Development

Successfully merging this pull request may close these issues.

3 participants