[BUGFIX] Fix entering Stress multiple times causing a crash #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
|
I forgot you use light mode for Discord. |
|
Also I think this fixes the issue I was having with both Stress songs where they would both take forever to exit out of. |
Hundrec
added
type: major bug
Member
|
We fixed this on the Polymod side, but would this be nice to have anyway? |
Contributor
Author
Since I have no idea how this was fixed on the Polymod side I'm going to say yes to the question, as the fix could be reverted at any point due to a bug or something, whereas this only depends on the onDestroy function getting activated with an event, which always happens without any issues. |
Hundrec
added
status: pending triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Funkin PR
N/A
Linked Issues
Description
The variable
tankmanGroupnever gets set to null after leaving the song due to someone assuming that songs have a kill function (which they don't).This PR changes that to using
onDestroy.Screenshots/Videos
2025-12-24.15-26-26.mp4