Make text asset caching opt-in #273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
goodies |
|
I love you thank you for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix this quite niche issue (FunkinCrew/Funkin#6675) which was introduced by the assets caching PR.
To sum it up, if you have a mod that constantly needs to modify a text file and later on you have to get the contents you've written, you'll just get the same thing instead of what was written to it due to the contents getting cached.
Since I don't think retrieving text files is something that happens a lot, or at least not in the base game, I think it's fine to disable this caching by default (although my actual reasoning for this is because I know that even if this is merged as an opt-out someone will forget to disable it)