Added baseline prompt and README example#6
Merged
jamesbraza merged 3 commits intomainfrom Jun 5, 2025
Merged
Conversation
7118c15 to
82d5e8c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a baseline prompt and example usage documentation for the ether0 benchmark while also updating dependency specifications to support the new baselines feature.
- Added a new constant (LOOSE_XML_ANSWER_USER_PROMPT) in model_prompts.py for XML-formatted SMILES answers.
- Updated pyproject.toml with new baselines dependencies.
- Extended README.md with benchmark instructions and a complete code snippet to run the evaluation.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ether0/model_prompts.py | Added a constant for XML-based SMILES answer prompts. |
| pyproject.toml | Added new dependencies required for running baselines. |
| README.md | Added detailed benchmark instructions and example evaluation snippet. |
Comments suppressed due to low confidence (2)
src/ether0/model_prompts.py:121
- [nitpick] Consider adding a comment above this constant to explain its purpose and usage context for future maintainers.
LOOSE_XML_ANSWER_USER_PROMPT = (
README.md:177
- Ensure that the use of 'await' at the top level is supported in your ipython environment or include guidance to wrap asynchronous calls inside an async function.
results = await asyncio.gather(
82d5e8c to
81260cd
Compare
whitead
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used
lmi/aviaryto run a baselines onether0-benchmarkwithgpt-4o.I also realized we didn't open source our baselines prompt yet.
Here is the printed output: