Moved mypy
to use local
hook to unsilence it on missing dependencies
#1055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this PR added missing dependencies to
pre-commit
'smypy
and removed the--ignore-missing-imports
to unsilence this error for the future.Then I hit errors like the below in this CI run:
And this made me realize we just needed a
local
hook. So this PR then moved us to use local `mypy.