test: use custom tmp directory

Author: G-Rath

__snapshots__/main_test.snap

@@ -60,39 +60,39 @@ You must provide at least one path to either a lockfile or a directory containin
 
 [TestRun_APIError/#00 - 1]
 Loaded the following OSV databases:
-  api#http://127.0.0.1:42805 (using batches of 1000)
+  api#http://127.0.0.1:37453 (using batches of 1000)
   RubyGems (%% vulnerabilities, including withdrawn - last updated %%)
 
-/tmp/TestRun_APIError#003124218549/001/Gemfile.lock: found 1 package
-  Using config at /tmp/TestRun_APIError#003124218549/001/.osv-detector.yml (0 ignores)
-  Using db api#http://127.0.0.1:42805 (using batches of 1000)
+<tempdir>/Gemfile.lock: found 1 package
+  Using config at <tempdir>/.osv-detector.yml (0 ignores)
+  Using db api#http://127.0.0.1:37453 (using batches of 1000)
   Using db RubyGems (%% vulnerabilities, including withdrawn - last updated %%)
 
   no known vulnerabilities found
 
 ---
 
 [TestRun_APIError/#00 - 2]
-  an api error occurred while trying to check the packages listed in /tmp/TestRun_APIError#003124218549/001/Gemfile.lock: api returned unexpected status (POST http://127.0.0.1:42805/querybatch 400)
+  an api error occurred while trying to check the packages listed in <tempdir>/Gemfile.lock: api returned unexpected status (POST http://127.0.0.1:37453/querybatch 400)
 
 ---
 
 [TestRun_APIError/#01 - 1]
 Loaded the following OSV databases:
-  api#http://127.0.0.1:36893 (using batches of 1000)
+  api#http://127.0.0.1:38803 (using batches of 1000)
   RubyGems (%% vulnerabilities, including withdrawn - last updated %%)
 
-/tmp/TestRun_APIError#01238228472/001/Gemfile.lock: found 1 package
-  Using config at /tmp/TestRun_APIError#01238228472/001/.osv-detector.yml (0 ignores)
-  Using db api#http://127.0.0.1:36893 (using batches of 1000)
+<tempdir>/Gemfile.lock: found 1 package
+  Using config at <tempdir>/.osv-detector.yml (0 ignores)
+  Using db api#http://127.0.0.1:38803 (using batches of 1000)
   Using db RubyGems (%% vulnerabilities, including withdrawn - last updated %%)
 
   no known vulnerabilities found
 
 ---
 
 [TestRun_APIError/#01 - 2]
-  an api error occurred while trying to check the packages listed in /tmp/TestRun_APIError#01238228472/001/Gemfile.lock: api response could not be parsed as json (POST http://127.0.0.1:36893/querybatch): invalid character '<' looking for beginning of value
+  an api error occurred while trying to check the packages listed in <tempdir>/Gemfile.lock: api response could not be parsed as json (POST http://127.0.0.1:38803/querybatch): invalid character '<' looking for beginning of value
 
 ---
 

main_test.go

@@ -859,12 +859,19 @@ func TestRun_APIError(t *testing.T) {
 		t.Run("", func(t *testing.T) {
 			t.Parallel()
 
-			tmp := t.TempDir()
+			//nolint:usetesting // we need to customize the directory name to replace in snapshots
+			p, err := os.MkdirTemp("", "osv-detector-test-*")
+			if err != nil {
+				t.Fatalf("could not create test directory: %v", err)
+			}
 
-			var err error
+			// ensure the test directory is removed when we're done testing
+			t.Cleanup(func() {
+				_ = os.RemoveAll(p)
+			})
 
 			// create a file for scanning
-			err = os.WriteFile(filepath.Join(tmp, "Gemfile.lock"), []byte(`
+			err = os.WriteFile(filepath.Join(p, "Gemfile.lock"), []byte(`
 GEM
   remote: https://rubygems.org/
   specs:
@@ -880,7 +887,7 @@ GEM
 			t.Cleanup(ts.Close)
 
 			// create a config file setting up our api server
-			err = os.WriteFile(filepath.Join(tmp, ".osv-detector.yml"), []byte(`
+			err = os.WriteFile(filepath.Join(p, ".osv-detector.yml"), []byte(`
 extra-databases:
   - url: `+ts.URL,
 			), 0600)
@@ -892,7 +899,7 @@ extra-databases:
 			// run the cli in our tmp directory
 			testCli(t, cliTestCase{
 				name: "",
-				args: []string{tmp},
+				args: []string{p},
 				exit: 127,
 			})
 		})