Conversation
Refactored DatabaseHandler to support parameterized queries using PreparedStatement. Updated MainController to use parameterized execAction and execQuery methods, eliminating SQL injection vulnerabilities in: - loadSubmissionOp - loadMemberInfo - loadIssueOperation - loadBookInfo2 - loadRenewOp Also fixed a resource loading bug in DatabaseHandler where tables.xml was loaded incorrectly. Added DatabaseHandlerExecTest and necessary stubs for verification. Co-authored-by: G30RG3-GJ <203693057+G30RG3-GJ@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes multiple SQL injection vulnerabilities in
MainController.javaby introducing parameterized query support inDatabaseHandler.java.Changes:
execAction(String query, Object... params)usingPreparedStatement.execQuery(String query, Object... params)usingPreparedStatement.inflateDBto correctly loadtables.xmlresource usingDatabaseHandler.class.getResourceAsStreaminstead of.getClass().getResourceAsStream.loadSubmissionOp,loadMemberInfo,loadIssueOperation,loadBookInfo2, andloadRenewOpto use the new parameterized methods.test/library/assistant/database/DatabaseHandlerExecTest.javato verify parameterized execution and SQL injection prevention.test/stubsto allow compilation ofDatabaseHandlerin the headless test environment.Security Impact:
PreparedStatementwhich treats parameters as literal values, neutralizing injection payloads.Verification:
DatabaseHandlerExecTestpasses, confirming thatexecActionworks with parameters and that SQL injection attempts (e.g.' OR '1'='1) are ineffective.PR created automatically by Jules for task 6378433451357861885 started by @G30RG3-GJ