Skip to content

🔒 Fix SQL Injection in MainController.loadBookInfo2#78

Open
G30RG3-GJ wants to merge 1 commit intomasterfrom
fix-sql-injection-maincontroller-17736137760575823557
Open

🔒 Fix SQL Injection in MainController.loadBookInfo2#78
G30RG3-GJ wants to merge 1 commit intomasterfrom
fix-sql-injection-maincontroller-17736137760575823557

Conversation

@G30RG3-GJ
Copy link
Owner

This PR fixes a SQL Injection vulnerability in src/library/assistant/ui/main/MainController.java. The loadBookInfo2 method was constructing a SQL query by concatenating the user-provided bookID directly into the string, making it vulnerable to injection attacks.

Changes:

  • Added getIssueDetails method to src/library/assistant/database/DataHelper.java. This method uses PreparedStatement to safely execute the query.
  • Updated src/library/assistant/ui/main/MainController.java to use DataHelper.getIssueDetails instead of executing the raw query string.
  • Added a unit test testGetIssueDetails in test/library/assistant/database/DataHelperTest.java to verify the fix and ensure the query is properly parameterized.

Risk:

  • If left unfixed, an attacker could manipulate the bookID input to execute arbitrary SQL commands, potentially reading sensitive data or modifying the database.

Verification:

  • Verified the query string logic.
  • Ran unit tests using run_tests.sh to confirm the new test passes and existing functionality is preserved.

PR created automatically by Jules for task 17736137760575823557 started by @G30RG3-GJ

Replaced the vulnerable string concatenation in `MainController.loadBookInfo2` with a parameterized query using `PreparedStatement`.
Extracted the database query logic to `DataHelper.getIssueDetails` to separate concerns and facilitate testing.
Added unit tests for `DataHelper.getIssueDetails` to verify secure query construction.

Co-authored-by: G30RG3-GJ <203693057+G30RG3-GJ@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant