Conversation
- Added `execUpdate(String query, Object... params)` to `DatabaseHandler` to support parameterized queries using `PreparedStatement`. - Updated `MainController.loadRenewOp`, `MainController.loadIssueOperation`, and `MainController.loadSubmissionOp` to use `execUpdate` instead of string concatenation. - This prevents SQL injection attacks where user input (book ID, member ID) is directly embedded in SQL statements. Co-authored-by: G30RG3-GJ <203693057+G30RG3-GJ@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixed SQL Injection vulnerabilities in
MainControllerby introducing a newexecUpdatemethod inDatabaseHandlerthat usesPreparedStatement. Vulnerable methodsloadRenewOp,loadIssueOperation, andloadSubmissionOpwere updated to use this safe method. Logic was verified using a standalone test script (deleted before submission).PR created automatically by Jules for task 17981076786792442244 started by @G30RG3-GJ