Skip to content

🔒 Fix Plain Text Password Storage for Long Passwords#84

Open
G30RG3-GJ wants to merge 1 commit intomasterfrom
fix-preferences-password-vulnerability-126410527248508142
Open

🔒 Fix Plain Text Password Storage for Long Passwords#84
G30RG3-GJ wants to merge 1 commit intomasterfrom
fix-preferences-password-vulnerability-126410527248508142

Conversation

@G30RG3-GJ
Copy link
Owner

This PR addresses a security vulnerability where passwords of length 16 or greater were stored in plain text in the Preferences configuration file.

The fix involves modifying Preferences.setPassword to always hash the password using DigestUtils.shaHex, consistent with the existing behavior for shorter passwords.

Changes:

  • Modified src/library/assistant/ui/settings/Preferences.java: Removed conditional logic that skipped hashing for long passwords.
  • Added test/library/assistant/ui/settings/PreferencesTest.java: New unit test to verify that both short and long passwords are correctly hashed.
  • Added test/stubs/library/assistant/alert/AlertMaker.java: Stub for AlertMaker to allow compiling Preferences (which has UI dependencies) in the headless test environment.

Verification:

  • Ran PreferencesTest (via custom script) to confirm the fix.
  • Ran existing run_tests.sh to ensure no regressions in other parts of the system.

PR created automatically by Jules for task 126410527248508142 started by @G30RG3-GJ

Always hash passwords in Preferences.java, regardless of length.
Added PreferencesTest.java to verify the fix and prevent regressions.
Added AlertMaker stub to facilitate testing in non-UI environment.

Co-authored-by: G30RG3-GJ <203693057+G30RG3-GJ@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant