🔒 Fix Plain Text Password Storage for Long Passwords#84
🔒 Fix Plain Text Password Storage for Long Passwords#84
Conversation
Always hash passwords in Preferences.java, regardless of length. Added PreferencesTest.java to verify the fix and prevent regressions. Added AlertMaker stub to facilitate testing in non-UI environment. Co-authored-by: G30RG3-GJ <203693057+G30RG3-GJ@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses a security vulnerability where passwords of length 16 or greater were stored in plain text in the
Preferencesconfiguration file.The fix involves modifying
Preferences.setPasswordto always hash the password usingDigestUtils.shaHex, consistent with the existing behavior for shorter passwords.Changes:
src/library/assistant/ui/settings/Preferences.java: Removed conditional logic that skipped hashing for long passwords.test/library/assistant/ui/settings/PreferencesTest.java: New unit test to verify that both short and long passwords are correctly hashed.test/stubs/library/assistant/alert/AlertMaker.java: Stub forAlertMakerto allow compilingPreferences(which has UI dependencies) in the headless test environment.Verification:
PreferencesTest(via custom script) to confirm the fix.run_tests.shto ensure no regressions in other parts of the system.PR created automatically by Jules for task 126410527248508142 started by @G30RG3-GJ