Skip to content

Refactor DatabaseHandler to close Statement resources#86

Open
G30RG3-GJ wants to merge 1 commit intomasterfrom
fix-database-resource-leak-6836904184848367231
Open

Refactor DatabaseHandler to close Statement resources#86
G30RG3-GJ wants to merge 1 commit intomasterfrom
fix-database-resource-leak-6836904184848367231

Conversation

@G30RG3-GJ
Copy link
Owner

Refactor execQuery to use Statement.closeOnCompletion() to ensure statements are closed when ResultSets are closed.
Refactor execAction, deleteBook, isBookAlreadyIssued, deleteMember, isMemberHasAnyBooks, updateBook, updateMember, and createTables to use try-with-resources for proper resource management.
Remove static stmt field to prevent thread-safety issues and resource leaks.
Add unit test DatabaseHandlerTest to verify resource management logic.


PR created automatically by Jules for task 6836904184848367231 started by @G30RG3-GJ

Refactor execQuery to use Statement.closeOnCompletion() to ensure statements are closed when ResultSets are closed.
Refactor execAction and other methods to use try-with-resources for proper resource management.
Remove static stmt field to prevent thread-safety issues and resource leaks.
Add unit test DatabaseHandlerTest to verify resource management logic.

Co-authored-by: G30RG3-GJ <203693057+G30RG3-GJ@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant