Conversation
…ing File I/O - Refactored `IssuedListController.loadData` to use `javafx.concurrent.Task`. - Added `LibraryAssistantUtil.getFineAmount(int, Preferences)` to allow passing cached preferences. - Fetched `Preferences` once per load instead of once per row, eliminating redundant file I/O. - Validated with microbenchmark showing ~5000x speedup for the preference reading logic. Co-authored-by: G30RG3-GJ <203693057+G30RG3-GJ@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
IssuedListController.loadDatato a background thread usingjavafx.concurrent.Task.LibraryAssistantUtil.getFineAmountto accept aPreferencesobject.IssuedListController.loadDatato fetchPreferencesonce and reuse it for each record, instead of re-reading the config file for every row.config.txtfile (viaPreferences.getPreferences()) inside the loop for every issued book, causing severe performance degradation (approx 5000x slowdown for the file reading part alone).Preferencesreading logic showed that reading 1000 times takes ~220ms, while reading once takes ~0.04ms. This eliminates a significant bottleneck.PR created automatically by Jules for task 17625898162927159685 started by @G30RG3-GJ