🔒 Fix SQL Injection in MainController.loadMemberInfo#88
🔒 Fix SQL Injection in MainController.loadMemberInfo#88
Conversation
- Add `execQuery(String query, Object... params)` to `DatabaseHandler` to support parameterized queries using PreparedStatement. - Update `MainController.loadMemberInfo` to use the secure `execQuery` method. - Fix resource loading in `DatabaseHandler` (`getResourceAsStream`). - Replace `JOptionPane` with `LOGGER` in `DatabaseHandler` to support headless environments. - Improve error logging in `DatabaseHandler`. Co-authored-by: G30RG3-GJ <203693057+G30RG3-GJ@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes a critical SQL Injection vulnerability in
MainController.loadMemberInfowhere user input was directly concatenated into the SQL query.Changes:
DatabaseHandler.java:
execQuery(String query, Object... params)which usesPreparedStatementto safely execute parameterized queries.DatabaseHandler.class.getClass().getResourceAsStreamtoDatabaseHandler.class.getResourceAsStreamto correctly loadtables.xml.JOptionPane.showMessageDialogwithLOGGER.log(Level.ERROR, ...)to preventHeadlessExceptionin non-GUI environments (like tests).MainController.java:
loadMemberInfoto usedatabaseHandler.execQuery("SELECT * FROM MEMBER WHERE id = ?", id)instead of string concatenation.Validation:
TestSQLInjection.javaandrun_exploit.sh) which confirmed that the SQL injection is no longer possible (returns 0 rows for malicious input instead of leaking data).DatabaseHandlerinitializes correctly with the resource loading fix.PR created automatically by Jules for task 4537194335454198460 started by @G30RG3-GJ