Skip to content

⚡ Fix unclosed PreparedStatement in DataHelper.insertNewBook #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
G30RG3-GJ wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡ Fix unclosed PreparedStatement in DataHelper.insertNewBook #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions run_tests.sh
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions src/library/assistant/database/DataHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ public static boolean insertNewBook(Book book) {
}

public static boolean insertNewBook(Book book, Connection conn) {
try {
PreparedStatement statement = conn.prepareStatement(
"INSERT INTO BOOK(id,title,author,publisher,isAvail) VALUES(?,?,?,?,?)");
try (PreparedStatement statement = conn.prepareStatement(
"INSERT INTO BOOK(id,title,author,publisher,isAvail) VALUES(?,?,?,?,?)")) {
statement.setString(1, book.getId());
statement.setString(2, book.getTitle());
statement.setString(3, book.getAuthor());
Expand Down
1 change: 1 addition & 0 deletions test/library/assistant/database/DataHelperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public void testInsertNewBook() throws SQLException {
verify(mockStmt).setString(4, "Test Publisher");
verify(mockStmt).setBoolean(5, true);
verify(mockStmt).executeUpdate();
verify(mockStmt).close();
}

@Test
Expand Down