Conversation
- Removed default "admin" username and password from Preferences constructor. - Modified LoginController to detect missing credentials and prompt for admin account creation. - Updated login.fxml with status label and fx:id for login button. - Added PreferencesTest to verify removal of default credentials and password hashing logic. - Added AlertMaker stub to allow compilation of Preferences in headless environment. Co-authored-by: G30RG3-GJ <203693057+G30RG3-GJ@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR addresses the security vulnerability of hardcoded default credentials.
Changes:
username = "admin"andsetPassword("admin")from the constructor.Preferenceshas a username set. If not, it enters a "Setup Mode" where the user can create an admin account. The new credentials are hashed and saved toconfig.txt.fx:idto the login button and a newLabelto display status messages (e.g., "First Run").PreferencesTest.javato verify thatPreferencesinitializes with null credentials and that password hashing works as expected. AddedAlertMakerstub to facilitate testing in an environment without JavaFX.PR created automatically by Jules for task 3405941572062292418 started by @G30RG3-GJ