Skip to content

trivial:유의미한 데이터를 log 로 남기기 #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rladmstn merged 12 commits into from
Apr 6, 2025
Merged

trivial:유의미한 데이터를 log 로 남기기 #338

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
137bd0d
group 수정
s-hwan Feb 22, 2025
3f07f93
notice log
s-hwan Feb 26, 2025
cc005c4
problem log 수정
s-hwan Feb 26, 2025
ac3e174
solution log 수정
s-hwan Feb 26, 2025
94e2a42
user log 수정
s-hwan Feb 26, 2025
4d83ffa
trivial:user,problem log 수정
s-hwan Mar 9, 2025
ed6c644
trivial : noti log 수정
s-hwan Mar 9, 2025
8fa270b
trivial:notice log 수정
s-hwan Mar 9, 2025
b2f0e2f
trivial:group log 수정
s-hwan Mar 9, 2025
3b1d65f
Merge branch 'develop' of https://github.com/GAMZA-BAT/ALGOHUB-SERVER…
s-hwan Mar 10, 2025
789903a
trivial:merge develop branch
s-hwan Mar 10, 2025
67d1fea
trivial:resolve conflict
s-hwan Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/main/java/com/gamzabat/algohub/feature/group/studygroup/service/StudyGroupService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public GroupCodeResponse createGroup(User user, CreateGroupRequest request, Mult
);

saveGroupImage(profileImage, group);
log.info("success to save study group");
log.info("success to save study group user_id={}", user.getId());
return new GroupCodeResponse(inviteCode);
}

Expand Down Expand Up @@ -154,7 +154,7 @@ public GetGroupIdResponse joinGroupWithCode(User user, String code) {
);

sendNewMemberNotification(studyGroup, member);
log.info("success to join study group");
log.info("success to join study group user_id={} ", user.getId());
Copy link
Contributor

@rladmstn rladmstn Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요런 것도 어떤 그룹에 참여했는지 정보 주면 좋지 않을까요?


return new GetGroupIdResponse(studyGroup.getId());

Expand All @@ -175,7 +175,7 @@ public void deleteGroup(User user, Long groupId) {

deleteAllAboutGroup(group);

log.info("success to delete study group");
log.info("success to delete study group user_id={}, group_id={}", user.getId(), groupId);
Copy link
Contributor

@rladmstn rladmstn Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런건 target user가 더 중요할까요 아님 탈퇴 시킨 user id가 더 중요할까요?
저는 target user도 들가면 좋긴 할 것 같은데 나중에 하시죠

}

private void deleteAllAboutGroup(StudyGroup group) {
Expand Down Expand Up @@ -216,7 +216,7 @@ public void exitGroup(User user, Long groupId) {
}
}

log.info("success to exit study group");
log.info("success to exit study group user_id={}", user.getId());
}

@Transactional
Expand All @@ -237,6 +237,7 @@ public void deleteMember(User user, Long userId, Long groupId) {
() -> new GroupMemberValidationException(HttpStatus.BAD_REQUEST.value(), "이미 참여하지 않은 회원입니다."));

studyGroupServiceProvider.getObject().deleteMemberFromStudyGroup(user, groupMember, group);
log.info("success to delete member user_id={}", user.getId());
} else {
throw new UserValidationException("멤버를 삭제 할 권한이 없습니다.");
}
Expand All @@ -250,7 +251,7 @@ public void deleteMemberFromStudyGroup(User user, GroupMember groupMember, Study
solutionRepository.deleteAllByStudyGroupAndUser(studyGroup, user);
noticeReadRepository.deleteAllByStudyGroupAndUser(studyGroup, user);
groupMemberRepository.delete(groupMember);
log.info("success to delete group member");
log.info("success to delete group member user_id = {}", user.getId());
}

@Transactional(readOnly = true)
Expand Down Expand Up @@ -336,7 +337,7 @@ public void editGroup(User user, Long groupId, EditGroupRequest request, Multipa
if (request.introduction() != null && !request.introduction().isEmpty())
group.editGroupIntroduction(request.introduction());

log.info("success to edit group info");
log.info("success to edit group info user_id={}", user.getId());
}

private void editGroupImage(MultipartFile inputImage, StudyGroup group, Boolean isDefaultImage) {
Expand Down Expand Up @@ -534,7 +535,7 @@ public void updateGroupMemberRole(User user, Long groupId, UpdateGroupMemberRole
if (RoleOfGroupMember.isOwner(member) && request.role() != null) {
owner.updateRole(RoleOfGroupMember.PARTICIPANT);
}
log.info("success to update group member role");
log.info("success to update group member role user_id={}", user.getId());
}

@Transactional(readOnly = true)
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/gamzabat/algohub/feature/notice/service/NoticeService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public CreateNoticeResponse createNotice(@AuthedUser User user, Long groupId, Cr
.category(request.category())
.createdAt(LocalDateTime.now())
.build());
log.info("success to create notice");
log.info("success to create notice user_id={}", user.getId());
return new CreateNoticeResponse(notice.getId());
}

Expand Down Expand Up @@ -131,7 +131,7 @@ public void updateNotice(User user, Long noticeId, UpdateNoticeRequest request)
if (request.category() != null) {
notice.updateCategory(request.category());
}
log.info("success to update notice");
log.info("success to update notice user_id={}", user.getId());
}

@Transactional
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/gamzabat/algohub/feature/problem/service/ProblemService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public void createProblem(User user, Long groupId, CreateProblemRequest request)
NotificationCategory.PROBLEM_STARTED.getMessage(title)
);

log.info("success to create problem");
log.info("success to create problem user_id={}", user.getId());
}

@Transactional
Expand All @@ -118,7 +118,7 @@ public void editProblem(User user, Long problemId, EditProblemRequest request) {
problem.editProblemEndDate(request.endDate());
}

log.info("success to edit problem deadline");
log.info("success to edit problem deadline user_id={}", user.getId());
}

private void checkProblemValidation(Problem problem) {
Expand Down Expand Up @@ -212,7 +212,7 @@ public void deleteProblem(User user, Long problemId) {

solutionRepository.deleteAllByProblem(problem);
problemRepository.delete(problem);
log.info("success to delete problem");
log.info("success to delete problem user_id={}", user.getId());
}

@Transactional(readOnly = true)
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/gamzabat/algohub/feature/solution/service/SolutionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ public void createSolution(CreateSolutionRequest request) {

sendNewSolutionNotification(studyGroup, member.get(), problem);
}
log.info("success to create solution user_id={}.", user.getId());
}

private void sendNewSolutionNotification(StudyGroup group, GroupMember solver, Problem problem) {
Expand Down
10 changes: 6 additions & 4 deletions src/main/java/com/gamzabat/algohub/feature/user/service/UserService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public void register(RegisterRequest request, MultipartFile profileImage) {
.build());

saveProfileImage(profileImage, user);
log.info("success to register");
log.info("success to register user_id={}", user.getId());
}

private void saveProfileImage(MultipartFile profileImage, User user) {
Expand Down Expand Up @@ -138,7 +138,7 @@ public void userUpdate(User user, UpdateUserRequest updateUserRequest, Multipart
}

userRepository.save(user);
log.info("success to update user");
log.info("success to update user user_id={}", user.getId());
}

private void editUserProfileImage(User user, MultipartFile inputImage, Boolean isDefaultImage) {
Expand Down Expand Up @@ -178,6 +178,7 @@ public void deleteUser(User user, DeleteUserRequest deleteUserRequest) {
throw new UncorrectedPasswordException("비밀번호가 틀렸습니다.");
}
userRepository.delete(user);
log.info("success to delete user user_id={}", user.getId());
}

@Transactional
Expand All @@ -198,6 +199,7 @@ public void editPassword(User user, EditUserPasswordRequest request) {
user.editPassword(encodedPassword);

userRepository.save(user);
log.info("success to edit password user_id={}", user.getId());
}

@Transactional(readOnly = true)
Expand All @@ -221,7 +223,7 @@ public void checkBjNickname(String bjNickname) {
log.error("BOJ server error occurred : " + e.getMessage());
throw new BOJServerErrorException("현재 백준 서버 오류가 발생했습니다. 잠시 후 다시 시도해주세요.");
}
log.info("success to check baekjoon nickname validity");
log.info("success to check baekjoon nickname validity nickname={}", bjNickname);
}

@Transactional(readOnly = true)
Expand All @@ -242,7 +244,7 @@ public void checkNickname(String nickname) {
if (userRepository.existsByNickname(nickname))
throw new CheckNicknameValidationException(HttpStatus.CONFLICT.value(), "이미 사용 중인 닉네임입니다.");

log.info("success to check nickname validity");
log.info("success to check nickname validity nickname={}", nickname);
}

@Transactional(readOnly = true)
Expand Down