Skip to content

refactor : 백준 API 호출 시 timeout 에러 처리 추가#395

Merged
sh0723 merged 2 commits intodevelopfrom
BE-31
Aug 25, 2025
Merged

refactor : 백준 API 호출 시 timeout 에러 처리 추가#395
sh0723 merged 2 commits intodevelopfrom
BE-31

Conversation

@junggyo1020
Copy link
Copy Markdown
Contributor

@junggyo1020 junggyo1020 commented Aug 24, 2025

📌 Related Issue

BE-31

🚀 Description

SocketTimeoutException에 대한 예외처리

  • Spring RestTemplateSocketTimeoutException(checkedException)에 대한 처리를 ResourceAccessException이라는 런타임 예외(unchecked exception)로 throw 하기때문에 해당 부분에 대한 예외처리를 추가했습니다!
  • 테스트 코드는 기존에 존재하는 형식을 따라 작성했습니다.

📢 Review Point

  • 더 추가해야할 예외처리가 있다면 말씀주시면 추가해두겠습니다 :)

📚Etc (선택)

@junggyo1020 junggyo1020 self-assigned this Aug 24, 2025
@junggyo1020 junggyo1020 added the bug 버그 수정 label Aug 24, 2025
@linear
Copy link
Copy Markdown

linear bot commented Aug 24, 2025

@junggyo1020 junggyo1020 added the refactoring 리팩토링 label Aug 24, 2025
@channeltalk
Copy link
Copy Markdown

channeltalk bot commented Aug 24, 2025

@github-actions
Copy link
Copy Markdown

Test Results

 18 files   18 suites   5s ⏱️
308 tests 308 ✅ 0 💤 0 ❌
310 runs  310 ✅ 0 💤 0 ❌

Results for commit aa38f1e.

Copy link
Copy Markdown
Contributor

@rladmstn rladmstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예외처리 좋습니다! 고생하셨어요!

Copy link
Copy Markdown
Contributor

@s-hwan s-hwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Copy link
Copy Markdown
Contributor

@sh0723 sh0723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요!!

@sh0723 sh0723 merged commit b2196c7 into develop Aug 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 버그 수정 refactoring 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants