Conversation
Test Results 19 files 19 suites 6s ⏱️ Results for commit 75fe441. |
rladmstn
reviewed
Sep 21, 2025
| @Operation(summary = "그룹 검색 API", description = "홈 화면에서 그룹을 검색하는 API") | ||
| public ResponseEntity<Page<GetGroupResponse>> getSearchedGroupList(@RequestParam String searchPattern, | ||
| @PageableDefault(size = 20, page = 0) Pageable pageable) { | ||
| @ParameterObject @PageableDefault(size = 20, sort = "id", direction = Sort.Direction.DESC, page = 0) Pageable pageable) { |
Contributor
There was a problem hiding this comment.
저 @ParameterObject도 이번 fix에 필요한 친구인가요??
찾아보니까 swagger에 필요한 친구라고 해서요!
Contributor
Author
There was a problem hiding this comment.
Swagger에 필요한 친구가 맞긴합니다.. 혹시,,또 버그가 생길까 무서워서 붙였습니다
Contributor
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋ일단 뭐 approve 하겠습니다..
Contributor
Author
There was a problem hiding this comment.
다 뜯어진 천조가리 기우기 하는 느낌... 일단 merge 하겠습니다..
Contributor
|
ㅋㅋㅋㅋㅋㅋ PR prefix fix도 아니고 bug는 뭐야! |
Contributor
Author
허걱... 내 코드는 bug다.. |
rladmstn
approved these changes
Sep 21, 2025
hwangjokim
pushed a commit
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Related Issue
BE-46
🚀 Description
📢 Review Point