Merged
Conversation
Test Results 19 files 19 suites 6s ⏱️ Results for commit 3a85c72. |
rladmstn
reviewed
Sep 28, 2025
Contributor
rladmstn
left a comment
rladmstn
left a comment
There was a problem hiding this comment.
딱히 피드백 드릴 부분이 크지 않네요! 수고하셨습니담
Comment on lines
+3
to
+4
| public record GetSolutionCommentActivity(Long solutionId, Long groupId) { | ||
| } |
Contributor
There was a problem hiding this comment.
오잉 생각보다 정보가 덜 필요하군요!
solutionId랑 groupId 주면 프론트가 댓글 목록이랑 풀이 모두 조회해서 사용하는걸까요??
처음엔 관련된 정보(ex: 댓글 작성자, 댓글 내용, 풀이 내용, soltuionId 등..)를 DTO에 다 담아서 모두 주는걸로 생각했었거든요!
Contributor
Author
There was a problem hiding this comment.
기존에 있던 API를 재사용하실 것 같더라구요! 그래서 solutionId와 groupId만 반환해달라고 요청받았습니다!
Contributor
There was a problem hiding this comment.
오호 프론트가 API 재사용을 야무지게 하나보네요 굿입니다 👍
hwangjokim
pushed a commit
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Related Issue
be-45
🚀 Description
📢 Review Point
📚Etc (선택)