refactor : 반례게시판

src/main/java/com/gamzabat/algohub/constants/ApiConstants.java

@@ -4,6 +4,7 @@ public final class ApiConstants {
 	public static final String SOLVED_AC_PROBLEM_API_URL = "https://solved.ac/api/v3/problem/lookup?problemIds=";
 	public static final String BOJ_USER_PROFILE_URL = "https://www.acmicpc.net/user/";
 	public static final String BOJ_PROBLEM_URL = "www.acmicpc.net";
+	public static final String BOJ_PROBLEM_FORMAT =  "https://www.acmicpc.net/problem/";
 	public static final String SERVER_HTTPS_ENDPOINT = "https://api.algohub.kr";
 	public static final String RC_SERVER_HTTPS_ENDPOINT = "https://api.rc.algohub.kr";
 

src/main/java/com/gamzabat/algohub/feature/edgecase/domain/EdgeCase.java

@@ -45,6 +45,7 @@ public class EdgeCase {
 	@JoinColumn(name = "user_id")
 	private User author;
 
+	private LocalDateTime createdAt;
 	private LocalDateTime deletedAt;
 
 	@Column(nullable = false)

src/main/java/com/gamzabat/algohub/feature/edgecase/dto/CreateEdgeCaseRequest.java

@@ -4,7 +4,7 @@
 import lombok.Builder;
 
 @Builder
-	public record CreateEdgeCaseRequest(@NotBlank(message = "문제 링크 입력은 필수입니다.")  String link,
+	public record CreateEdgeCaseRequest(@NotBlank(message = "문제 링크 또는 문제 번호 입력은 필수입니다.")  String linkOrProblemNumber,
 										@NotBlank(message = "반례 input 입력은 필수입니다.")  String input,
 										@NotBlank(message = "반례 output 입력은 필수입니다.")  String output){
 }

src/main/java/com/gamzabat/algohub/feature/edgecase/repository/EdgeCaseRepository.java

@@ -7,5 +7,6 @@
 import com.gamzabat.algohub.feature.edgecase.domain.EdgeCase;
 
 public interface EdgeCaseRepository extends JpaRepository<EdgeCase, Long> {
-	List<EdgeCase> findAllByProblemNumber(Integer number);
+	List<EdgeCase> findAllByProblemNumberOrderByCreatedAtDesc(Integer problemNumber);
+	List<EdgeCase> findAllByOrderByCreatedAtDesc();
 }

src/main/java/com/gamzabat/algohub/feature/edgecase/service/EdgeCaseService.java

@@ -37,29 +37,36 @@ public class EdgeCaseService {
 
 	public void createEdgeCase(User user, CreateEdgeCaseRequest request) {
 		User author = user;
-		String link = request.link();
+		Boolean isNumber = isNumeric(request.linkOrProblemNumber());
+		String link, number;
+		if (isNumber) {
+			link = BOJ_PROBLEM_FORMAT + request.linkOrProblemNumber();
+			number = request.linkOrProblemNumber();
+		} else {
+			link = request.linkOrProblemNumber();
+			number = getProblemId(link);
+		}
 
-		String number = getProblemId(link);
 		JsonNode apiResult = problemService.fetchProblemDetails(number);
 		int level = problemService.getProblemLevel(apiResult);
 		String title = problemService.getProblemTitle(apiResult);
 
-		saveEdgeCase(author,request,level,title,Integer.parseInt(number));
+		saveEdgeCase(author,request,link,level,title,Integer.parseInt(number));
 	}
 
-	private void saveEdgeCase(User author, CreateEdgeCaseRequest request, int level, String title, int number) {
+	private void saveEdgeCase(User author, CreateEdgeCaseRequest request, String link, int level, String title, int number) {
 		EdgeCase edgeCase = EdgeCase.builder().input(request.input()).level(level).title(title).link(
-			request.link()).output(request.output()).problemNumber(number).author(author).build();
+			link).output(request.output()).problemNumber(number).author(author).build();
 
 		edgeCaseRepository.save(edgeCase);
 	}
 
 	public GetEdgeCaseListResponse getEdgeCaseList(Integer problemNumber) {
 		List<EdgeCase> edgeCaseList;
 		if (problemNumber == null)
-			edgeCaseList = edgeCaseRepository.findAll();
+			edgeCaseList = edgeCaseRepository.findAllByOrderByCreatedAtDesc();
 		else
-			edgeCaseList = edgeCaseRepository.findAllByProblemNumber(problemNumber);
+			edgeCaseList = edgeCaseRepository.findAllByProblemNumberOrderByCreatedAtDesc(problemNumber);
 
 		List<GetEdgeCaseResponse> responseList = edgeCaseList.stream()
 			.map(edgeCase -> new GetEdgeCaseResponse(
@@ -115,4 +122,8 @@ private String getProblemId(String url) {
 			throw new NotBojLinkException(HttpStatus.BAD_REQUEST.value(), "백준 링크가 아닙니다");
 		return parts[parts.length - 1];
 	}
+
+	private boolean isNumeric(String str) {
+		return str != null && str.matches("\\d+");
+	}
 }

src/test/java/com/gamzabat/algohub/service/EdgeCaseServiceTest.java

@@ -120,7 +120,7 @@ void setUp() throws NoSuchFieldException, IllegalAccessException {
 	void createEdgeCaseSuccess() {
 		//given
 		CreateEdgeCaseRequest request = CreateEdgeCaseRequest.builder()
-			.link("https://www.acmicpc.net/problem/1000")
+			.linkOrProblemNumber("https://www.acmicpc.net/problem/1000")
 			.input("1 2")
 			.output("3")
 			.build();
@@ -156,7 +156,7 @@ void getEdgeCaseListSuccess_1() {
 		//given
 		Integer problemNumber = 1001;
 		List<EdgeCase> edgeCaseList = Arrays.asList(edgeCase1, edgeCase2);
-		when(edgeCaseRepository.findAllByProblemNumber(problemNumber))
+		when(edgeCaseRepository.findAllByProblemNumberOrderByCreatedAtDesc(problemNumber))
 			.thenReturn(edgeCaseList);
 
 		//when
@@ -186,7 +186,7 @@ void getEdgeCaseListSuccess_2() {
 		// given
 		Integer problemNumber = null;
 		List<EdgeCase> edgeCaseList = Arrays.asList(edgeCase1, edgeCase2, edgeCase3);
-		when(edgeCaseRepository.findAll())
+		when(edgeCaseRepository.findAllByOrderByCreatedAtDesc())
 			.thenReturn(edgeCaseList);
 		// when
 		GetEdgeCaseListResponse response = edgeCaseService.getEdgeCaseList(problemNumber);