Apply nextcloud coding standards

[lennartdohmann]

No description provided.

[Copilot]

Pull Request Overview

This pull request applies Nextcloud coding standards to the codebase, primarily focusing on license header compliance and code style consistency. The changes include adding SPDX license headers to all files, updating coding standards configurations, reorganizing some code structure, and making minor version updates.

• Adds SPDX license headers (AGPL-3.0-or-later) to all source files and license files for assets
• Updates PHP coding standards configuration and applies formatting improvements
• Reorganizes some code structure and adds missing override attributes
• Updates dependency versions and development tooling

Reviewed Changes

Copilot reviewed 93 out of 100 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
lib/**/*.php	Added SPDX headers and applied coding standards formatting
src/**/*.js	Added SPDX headers and minor formatting improvements
tests/**/*.php	Added SPDX headers and updated test formatting
img/**/*.license	Added license files for image assets
.php-cs-fixer.dist.php	New coding standards configuration file
composer.json	Updated dependency versions and scripts
Various config files	Added SPDX headers and minor updates

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

[nitpick] String concatenation should use template literals for better readability. Consider using: showWarning(t('gdatavaas', \The file "${file.basename}" has been scanned with G DATA as verdict PUP (Potentially unwanted program)`))`

Suggested change

	'verdict PUP (Potentially unwanted program)'));
	showWarning(t('gdatavaas', `The file "${file.basename}" has been scanned with G DATA as verdict PUP (Potentially unwanted program)`));

[Copilot]

[nitpick] Import statements should be grouped with framework imports before application imports. The TestLogger import should come after the OCA\GDataVaas imports.

Suggested change

	use OCA\GDataVaas\Service\VerdictService;
	use OCA\GDataVaas\AppInfo\Application;
	use OCA\GDataVaas\Service\FileService;
	use OCA\GDataVaas\Service\TagService;
	use OCA\GDataVaas\Service\VerdictService;
	use ColinODell\PsrTestLogger\TestLogger;

[Copilot]

[nitpick] Import of OC\User\NoUserException should be grouped with other OC imports and placed before OCA imports to follow typical import ordering conventions.

[Copilot]

[nitpick] The error message spans multiple lines in an inconsistent way. Consider using a single concatenated string or proper multi-line string formatting for better readability.

Suggested change

	ID '{$node->getId()}': {$e->getMessage()}"
	"Failed to scan uploaded file '{$node->getName()}' with ID '{$node->getId()}': {$e->getMessage()}"

[Copilot]

[nitpick] Long error message string is split across multiple lines inconsistently. Consider using a single string or proper multi-line string formatting for better readability.

Suggested change

	check the logs for more information and contact your administrator."], 500);
	['error' => "An unexpected error occurred while scanning file $fileId with GData VaaS. Please check the logs for more information and contact your administrator."], 500);

[Copilot]

[nitpick] Array formatting is inconsistent with line breaks in the middle of array elements. Consider keeping each complete array element on a single line or use consistent multi-line formatting.

Suggested change

	=> '/setSendMailSummaryOfMaliciousFiles', 'verb' => 'POST']
	['name' => 'settings#getSendMailSummaryOfMaliciousFiles', 'url' => '/getSendMailSummaryOfMaliciousFiles', 'verb' => 'GET'],
	['name' => 'settings#setSendMailSummaryOfMaliciousFiles', 'url' => '/setSendMailSummaryOfMaliciousFiles', 'verb' => 'POST']

[Copilot]

[nitpick] Method call is unnecessarily split across multiple lines with inconsistent indentation. Consider using a single line or proper multi-line formatting with consistent indentation.

Suggested change

	);
	$appConfig
	->method('getValueBool')
	->with(Application::APP_ID, 'disableUnscannedTag')
	->willReturn(true);