Add maximum scan size setting

[lennartdohmann]

No description provided.

[Copilot]

Pull Request Overview

This PR adds a configurable maximum scan size setting to replace the hardcoded file size limit. Users can now set a custom maximum file size (in MB) for virus scanning through the admin interface.

• Replaces hardcoded 1GB file size limit with configurable setting
• Adds admin UI form field for maximum scan size configuration
• Updates error messages to use the configurable limit instead of hardcoded values

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
templates/admin.php	Adds form input field for maximum scan size setting
src/admin-settings.js	Includes max scan size in form submission data
lib/Settings/VaasAdmin.php	Provides max scan size value to admin template
lib/Service/VerdictService.php	Replaces hardcoded limit with configurable setting
lib/Service/ScanService.php	Updates error message to use configurable limit
lib/Controller/SettingsController.php	Handles saving of max scan size setting with validation
lib/Controller/ScanController.php	Updates error message to use configurable limit
tests/bats/functionality-parallel.bats	Adjusts test file size to match new default limit

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The validation only checks for values less than 1, but doesn't handle the case where maxScanSize is null or empty string. This could cause unexpected behavior when casting to int.

Suggested change

	return new JSONResponse(['status' => 'error', 'message' => 'Invalid max scan size: ' . $maxScanSize]);
	if ($maxScanSize === null || $maxScanSize === '' || !is_numeric($maxScanSize) || (int)$maxScanSize < 1) {
	return new JSONResponse(['status' => 'error', 'message' => 'Invalid max scan size: ' . var_export($maxScanSize, true)]);

[Copilot]

Changing this method from static to instance method is a breaking change that could cause errors in other parts of the codebase that call VerdictService::isFileTooLargeToScan() statically.

[Copilot]

The escaped single quote in "Won't Scan" should use proper PHP string escaping. Consider using double quotes for the outer string to avoid confusion.

Suggested change

	<td><div title="<?php p($l->t('The maximum scan size for files to be scanned in MB. Files above this limit are tagged as “Won\'t Scan”.'));?>" class="visible"><label for="max-scan-size"><?php p($l->t('Maximum scan size'));?></label></div></td>
	<td><div title="<?php p($l->t("The maximum scan size for files to be scanned in MB. Files above this limit are tagged as “Won't Scan”."));?>" class="visible"><label for="max-scan-size"><?php p($l->t('Maximum scan size'));?></label></div></td>