Devcontainer and Workflow Performance #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lennartdohmann
force-pushed
the
cleanup
branch
2 times, most recently
from
832a9e5 to
9cd9ba1
Compare
lennartdohmann
changed the title
- Faster local development in devcontainer - Add Make stages for local fast developing as well as unit and bats tests - Remove unmaintained files from old debugging sessions
lennartdohmann
force-pushed
the
cleanup
branch
from
1fd1954 to
0c71a7b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on improving development workflow performance by removing old debugging files and simplifying the development environment setup. The changes aim to make local development faster and more streamlined by eliminating unmaintained debugging configurations and updating build processes.
- Remove legacy debugging configurations (xdebug, custom Docker builds, VSCode settings)
- Simplify development workflow with updated Make targets and environment setup
- Update CI/CD workflows to be more efficient and focused
Reviewed Changes
Copilot reviewed 31 out of 33 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| xdebug.local.ini, xdebug.ini, memory.ini | Remove old xdebug and memory configuration files |
| use-packagist-vaas.sh, use-local-vaas.sh | Remove legacy VaaS dependency management scripts |
| Dockerfile.Nextcloud, devcontainer.yaml | Remove custom Docker configurations |
| .vscode/* | Remove VSCode-specific debug and settings configurations |
| composer.local.vaas.json* | Remove local VaaS composer configuration files |
| tests/bats/functionality-parallel.bats | Remove extensive debugging code from test files |
| scripts/* | Update build and setup scripts for simplified workflow |
| Makefile | Add new targets for unit tests, bats tests, and streamlined builds |
| docker-compose.yaml | Simplify to use standard Nextcloud image without custom builds |
| .devcontainer/devcontainer.json | Update to PHP 8.4 and remove debugging extensions |
| .github/workflows/* | Split tests and release workflows, update dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+8
to
+14
| if [[ "$IS_CI" == 1 ]]; then | ||
| export HOSTNAME=nextcloud-container | ||
| else | ||
| export HOSTNAME=127.0.0.1 | ||
| export HOSTNAME=127.0.0.1:8080 | ||
| fi | ||
|
|
||
| if [[ "$IS_CI" == "true" ]]; then | ||
| if [[ "$IS_CI" == 1 ]]; then |
There was a problem hiding this comment.
Inconsistent comparison type. The variable IS_CI is being compared as a number (1) but may be set as a string. Use consistent string comparison: if [[ \"$IS_CI\" == \"1\" ]]; then
Comment on lines
+8
to
+14
| if [[ "$IS_CI" == 1 ]]; then | ||
| export HOSTNAME=nextcloud-container | ||
| else | ||
| export HOSTNAME=127.0.0.1 | ||
| export HOSTNAME=127.0.0.1:8080 | ||
| fi | ||
|
|
||
| if [[ "$IS_CI" == "true" ]]; then | ||
| if [[ "$IS_CI" == 1 ]]; then |
There was a problem hiding this comment.
Inconsistent comparison type. The variable IS_CI is being compared as a number (1) but may be set as a string. Use consistent string comparison: if [[ \"$IS_CI\" == \"1\" ]]; then
lennartdohmann
added a commit
that referenced
this pull request
Aug 28, 2025
* fix: correct syntax error in ScanService.php for constant declaration for PHP < 8.3 (#227) * chore(deps): update dependency webpack-dev-server to v5.2.2 (#225) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update all non-major dependencies (#231) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update dependency psalm/phar to v6.13.0 (#232) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update all non-major dependencies (#233) Co-authored-by: Renovate Bot <[email protected]> * Add a quicker way for development with a local Nextcloud server and the app code changeable inside this server (#234) * Add Nextclouds worklfow templates and apply Nextcloud coding style (#235) * Add maximum scan size setting for file uploads (#236) * Devcontainer and Workflow Performance (#237) - Faster local development in devcontainer - Add Make stages for local fast developing as well as unit and bats tests - Remove unmaintained files from old debugging sessions` - Cleanup unused files and bundle utility scripts * Settings improvements (#238) - Add button to test current vaas configuration - Rename app settings to be more intuitive * Add additional settings (#239) - Control scan timeout - Control usage of cache - Control usage of hash lookup * Refactor logging messages and remove redundant debug statements (#240) * Update README with development environment setup instructions (#241) * Remove unused settings (#242) - Malicious file notifications summary - Scan only new files * Add make target for production like local setup (#243) * Outsource file scan actions (#244) --------- Co-authored-by: vaas-bot <[email protected]> Co-authored-by: Renovate Bot <[email protected]>
lennartdohmann
added a commit
that referenced
this pull request
Aug 28, 2025
* fix: correct syntax error in ScanService.php for constant declaration for PHP < 8.3 (#227) * Add a quicker way for development with a local Nextcloud server and the app code changeable inside this server (#234) * Add Nextclouds worklfow templates and apply Nextcloud coding style (#235) * Add maximum scan size setting for file uploads (#236) * Devcontainer and Workflow Performance (#237) - Faster local development in devcontainer - Add Make stages for local fast developing as well as unit and bats tests - Remove unmaintained files from old debugging sessions` - Cleanup unused files and bundle utility scripts * Settings improvements (#238) - Add button to test current vaas configuration - Rename app settings to be more intuitive * Add additional settings (#239) - Control scan timeout - Control usage of cache - Control usage of hash lookup * Refactor logging messages and remove redundant debug statements (#240) * Update README with development environment setup instructions (#241) * Remove unused settings (#242) - Malicious file notifications summary - Scan only new files * Add make target for production like local setup (#243) * Outsource file scan actions (#244)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devcontainer and Workflow Performance by removing old debug stuff.
Makestages for local fast developing as well as unit and bats tests