-
Notifications
You must be signed in to change notification settings - Fork 1
Settings improvements #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lennartdohmann
commented
Aug 26, 2025
- Add button to test current vaas configuration
- Rename app settings to be more intuitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the settings interface by adding a test button for VaaS configuration validation and making UI text more intuitive for end users.
- Adds a "Test" button to verify VaaS configuration and connectivity
- Renames "Verdict-as-a-Service" to "G DATA Antivirus" throughout the UI
- Updates heading hierarchy for better visual structure
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/admin.php | Updates UI labels and adds test button to admin interface |
| src/admin-settings.js | Implements client-side test functionality with API call |
| lib/Controller/SettingsController.php | Adds backend test endpoint for VaaS configuration validation |
| lib/Service/VerdictService.php | Modifies authenticator method to accept token endpoint parameter |
| lib/Settings/VaasAdminSection.php | Renames section title to "G DATA Antivirus" |
| tests/unittests/VerdictServiceTest.php | Updates test to match new authenticator method signature |
| appinfo/routes.php | Adds route for test settings endpoint |
| Makefile | Excludes additional config file from build |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| 'message' => 'Authentication failed. Please also check your login details above and save them before | ||
| taking the test. ' . $e->getMessage() |
Copilot
AI
Aug 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message string is split across multiple lines in an inconsistent way. Consider using a single concatenated string or proper multi-line string syntax for better readability.
| 'message' => 'Authentication failed. Please also check your login details above and save them before | |
| taking the test. ' . $e->getMessage() | |
| 'message' => 'Authentication failed. Please also check your login details above and save them before taking the test. ' . $e->getMessage() |
| private string $clientId; | ||
| private string $clientSecret; | ||
| private string $authMethod; | ||
| public string $authMethod; |
Copilot
AI
Aug 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the visibility of $authMethod from private to public breaks encapsulation. Consider adding a getter method instead of exposing the property directly.
| public string $authMethod; | |
| private string $authMethod; |
- Add button to test current vaas configuration - Rename app settings to be more intuitive
cdf4cb5 to
ddad4f9
Compare
* fix: correct syntax error in ScanService.php for constant declaration for PHP < 8.3 (#227) * chore(deps): update dependency webpack-dev-server to v5.2.2 (#225) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update all non-major dependencies (#231) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update dependency psalm/phar to v6.13.0 (#232) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update all non-major dependencies (#233) Co-authored-by: Renovate Bot <[email protected]> * Add a quicker way for development with a local Nextcloud server and the app code changeable inside this server (#234) * Add Nextclouds worklfow templates and apply Nextcloud coding style (#235) * Add maximum scan size setting for file uploads (#236) * Devcontainer and Workflow Performance (#237) - Faster local development in devcontainer - Add Make stages for local fast developing as well as unit and bats tests - Remove unmaintained files from old debugging sessions` - Cleanup unused files and bundle utility scripts * Settings improvements (#238) - Add button to test current vaas configuration - Rename app settings to be more intuitive * Add additional settings (#239) - Control scan timeout - Control usage of cache - Control usage of hash lookup * Refactor logging messages and remove redundant debug statements (#240) * Update README with development environment setup instructions (#241) * Remove unused settings (#242) - Malicious file notifications summary - Scan only new files * Add make target for production like local setup (#243) * Outsource file scan actions (#244) --------- Co-authored-by: vaas-bot <[email protected]> Co-authored-by: Renovate Bot <[email protected]>
* fix: correct syntax error in ScanService.php for constant declaration for PHP < 8.3 (#227) * Add a quicker way for development with a local Nextcloud server and the app code changeable inside this server (#234) * Add Nextclouds worklfow templates and apply Nextcloud coding style (#235) * Add maximum scan size setting for file uploads (#236) * Devcontainer and Workflow Performance (#237) - Faster local development in devcontainer - Add Make stages for local fast developing as well as unit and bats tests - Remove unmaintained files from old debugging sessions` - Cleanup unused files and bundle utility scripts * Settings improvements (#238) - Add button to test current vaas configuration - Rename app settings to be more intuitive * Add additional settings (#239) - Control scan timeout - Control usage of cache - Control usage of hash lookup * Refactor logging messages and remove redundant debug statements (#240) * Update README with development environment setup instructions (#241) * Remove unused settings (#242) - Malicious file notifications summary - Scan only new files * Add make target for production like local setup (#243) * Outsource file scan actions (#244)