Skip to content

Conversation

@lennartdohmann
Copy link
Member

  • Control scan timeout
  • Control usage of cache
  • Control usage of hash lookup

@lennartdohmann lennartdohmann requested a review from Copilot August 26, 2025 15:01
@lennartdohmann lennartdohmann self-assigned this Aug 26, 2025

This comment was marked as outdated.

- Control scan timeout
- Control usage of cache
- Control usage of hash lookup
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds additional configuration settings to control the VaaS (Virus-as-a-Service) scanning behavior, specifically allowing administrators to configure scan timeout, cache usage, and hash lookup functionality.

  • Adds three new configuration options: timeout, cache, and hash lookup settings
  • Updates the admin settings interface to include input fields for the new options
  • Implements backend support for storing and retrieving the new configuration values

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
templates/admin.php Adds UI elements for timeout, cache, and hash lookup settings
src/admin-settings.js Implements frontend logic to handle new settings and API calls
lib/Settings/VaasAdmin.php Provides default values for new settings in the admin form
lib/Service/VerdictService.php Updates VaasOptions configuration to use the new settings
lib/Controller/SettingsController.php Adds backend validation and storage for new settings
css/style.css Adds styling for checkbox inputs in the settings table
appinfo/routes.php Adds new API routes for retrieving cache and hash lookup settings
src/files-action.js Adds try-catch error handling for file scanning
tests/bats/functionality-*.bats Updates test setup and removes unnecessary Docker commands
Makefile Adds composer install to local target
.devcontainer/devcontainer.json Updates VS Code extensions configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lennartdohmann lennartdohmann marked this pull request as ready for review August 26, 2025 15:11
@lennartdohmann lennartdohmann merged commit 2c4735f into main Aug 26, 2025
18 checks passed
@lennartdohmann lennartdohmann deleted the add-vaas-settings branch August 26, 2025 15:16
lennartdohmann added a commit that referenced this pull request Aug 28, 2025
* fix: correct syntax error in ScanService.php for constant declaration for PHP < 8.3 (#227)

* chore(deps): update dependency webpack-dev-server to v5.2.2 (#225)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps): update all non-major dependencies (#231)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps): update dependency psalm/phar to v6.13.0 (#232)

Co-authored-by: Renovate Bot <[email protected]>

* chore(deps): update all non-major dependencies (#233)

Co-authored-by: Renovate Bot <[email protected]>

* Add a quicker way for development with a local Nextcloud server and the app code changeable inside this server (#234)

* Add Nextclouds worklfow templates and apply Nextcloud coding style (#235)

* Add maximum scan size setting for file uploads (#236)

* Devcontainer and Workflow Performance (#237)

- Faster local development in devcontainer
- Add Make stages for local fast developing as well as unit and bats tests
- Remove unmaintained files from old debugging sessions`
- Cleanup unused files and bundle utility scripts

* Settings improvements (#238)

- Add button to test current vaas configuration
- Rename app settings to be more intuitive

* Add additional settings (#239)

- Control scan timeout
- Control usage of cache
- Control usage of hash lookup

* Refactor logging messages and remove redundant debug statements (#240)

* Update README with development environment setup instructions (#241)

* Remove unused settings (#242)

- Malicious file notifications summary
- Scan only new files

* Add make target for production like local setup (#243)

* Outsource file scan actions (#244)

---------

Co-authored-by: vaas-bot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
lennartdohmann added a commit that referenced this pull request Aug 28, 2025
* fix: correct syntax error in ScanService.php for constant declaration for PHP < 8.3 (#227)

* Add a quicker way for development with a local Nextcloud server and the app code changeable inside this server (#234)

* Add Nextclouds worklfow templates and apply Nextcloud coding style (#235)

* Add maximum scan size setting for file uploads (#236)

* Devcontainer and Workflow Performance (#237)

- Faster local development in devcontainer
- Add Make stages for local fast developing as well as unit and bats tests
- Remove unmaintained files from old debugging sessions`
- Cleanup unused files and bundle utility scripts

* Settings improvements (#238)

- Add button to test current vaas configuration
- Rename app settings to be more intuitive

* Add additional settings (#239)

- Control scan timeout
- Control usage of cache
- Control usage of hash lookup

* Refactor logging messages and remove redundant debug statements (#240)

* Update README with development environment setup instructions (#241)

* Remove unused settings (#242)

- Malicious file notifications summary
- Scan only new files

* Add make target for production like local setup (#243)

* Outsource file scan actions (#244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants