Remove unused settings #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lennartdohmann
commented
Aug 27, 2025
lennartdohmann
commented
- Malicious file notifications summary
- Scan only new files
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused settings related to malicious file notifications and new file scanning features. The changes streamline the admin configuration by eliminating functionality that is no longer needed.
- Removes the "Send weekly mails with a summary of malicious files" setting from the admin interface
- Removes the "Scan only new files" configuration option
- Deletes the associated background job and mail service methods for weekly summaries
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| templates/admin.php | Removes the malicious file summary email checkbox from admin UI |
| src/admin-settings.js | Removes JavaScript handlers and initialization for deleted settings |
| lib/Settings/VaasAdmin.php | Removes configuration parameters for deleted features |
| lib/Service/MailService.php | Removes weekly summary notification methods |
| lib/Controller/SettingsController.php | Removes API endpoints for deleted settings |
| lib/BackgroundJobs/NotifyAdminJob.php | Completely removes the background job file |
| appinfo/routes.php | Removes route definitions for deleted API endpoints |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lennartdohmann
force-pushed
the
remove-unused-settings
branch
2 times, most recently
from
7d964ea to
b9cef8b
Compare
- Malicious file notifications summary - Scan only new files
lennartdohmann
force-pushed
the
remove-unused-settings
branch
from
b9cef8b to
22c4aa1
Compare
lennartdohmann
added a commit
that referenced
this pull request
Aug 28, 2025
* fix: correct syntax error in ScanService.php for constant declaration for PHP < 8.3 (#227) * chore(deps): update dependency webpack-dev-server to v5.2.2 (#225) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update all non-major dependencies (#231) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update dependency psalm/phar to v6.13.0 (#232) Co-authored-by: Renovate Bot <[email protected]> * chore(deps): update all non-major dependencies (#233) Co-authored-by: Renovate Bot <[email protected]> * Add a quicker way for development with a local Nextcloud server and the app code changeable inside this server (#234) * Add Nextclouds worklfow templates and apply Nextcloud coding style (#235) * Add maximum scan size setting for file uploads (#236) * Devcontainer and Workflow Performance (#237) - Faster local development in devcontainer - Add Make stages for local fast developing as well as unit and bats tests - Remove unmaintained files from old debugging sessions` - Cleanup unused files and bundle utility scripts * Settings improvements (#238) - Add button to test current vaas configuration - Rename app settings to be more intuitive * Add additional settings (#239) - Control scan timeout - Control usage of cache - Control usage of hash lookup * Refactor logging messages and remove redundant debug statements (#240) * Update README with development environment setup instructions (#241) * Remove unused settings (#242) - Malicious file notifications summary - Scan only new files * Add make target for production like local setup (#243) * Outsource file scan actions (#244) --------- Co-authored-by: vaas-bot <[email protected]> Co-authored-by: Renovate Bot <[email protected]>
lennartdohmann
added a commit
that referenced
this pull request
Aug 28, 2025
* fix: correct syntax error in ScanService.php for constant declaration for PHP < 8.3 (#227) * Add a quicker way for development with a local Nextcloud server and the app code changeable inside this server (#234) * Add Nextclouds worklfow templates and apply Nextcloud coding style (#235) * Add maximum scan size setting for file uploads (#236) * Devcontainer and Workflow Performance (#237) - Faster local development in devcontainer - Add Make stages for local fast developing as well as unit and bats tests - Remove unmaintained files from old debugging sessions` - Cleanup unused files and bundle utility scripts * Settings improvements (#238) - Add button to test current vaas configuration - Rename app settings to be more intuitive * Add additional settings (#239) - Control scan timeout - Control usage of cache - Control usage of hash lookup * Refactor logging messages and remove redundant debug statements (#240) * Update README with development environment setup instructions (#241) * Remove unused settings (#242) - Malicious file notifications summary - Scan only new files * Add make target for production like local setup (#243) * Outsource file scan actions (#244)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.