Skip to content

Conversation

@kaswhy
Copy link
Member

@kaswhy kaswhy commented Aug 23, 2025

📌 연관된 이슈

✨ 작업 내용

aws 관련 환경 변수 오타 수정

💬 리뷰 요구사항(선택)

Summary by CodeRabbit

  • New Features
    • 해당 PR은 사용자 기능 추가를 포함하지 않습니다.
  • Chores
    • 개발 환경에서 테스트 리소스용 S3 버킷을 가리키는 환경 변수 매핑을 업데이트했습니다.
    • 최종 사용자 기능, 성능, UI 변화는 없으며 기존 동작은 유지됩니다.
    • 배포/로컬 실행 및 CI/CD 설정에서 환경 변수 키를 최신 값으로 교체해야 합니다. 누락·오설정 시 테스트 리소스 로딩이 실패할 수 있으므로 설정을 확인해 주세요.

@kaswhy kaswhy self-assigned this Aug 23, 2025
@kaswhy kaswhy added the bug Something isn't working label Aug 23, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 23, 2025

Walkthrough

개발 환경 설정 파일에서 S3 버킷 환경변수 참조를 ${WS_TEST_RESOURCE_BUCKET}에서 ${AWS_TEST_RESOURCE_BUCKET}로 변경했습니다. 다른 설정은 그대로입니다.

Changes

Cohort / File(s) Change Summary
구성 설정 변경
gdgoc/src/main/resources/application-dev.yml
cloud.aws.s3.bucket의 환경변수 키를 ${WS_TEST_RESOURCE_BUCKET}${AWS_TEST_RESOURCE_BUCKET}로 교체

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

토끼는 깡총, 버킷 키를 톡 바꿔놓고,
구름 상자 주소만 살짝 고쳐놓고,
개발 바람 솔솔, 설정은 반짝,
S3 길잡이 새 표지로 착!
오늘도 깃 잎 사이로 점프-점프 🐇✨

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/issue-70

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

CI status
✅ Assemble 성공
✅ Test 성공

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
gdgoc/src/main/resources/application-dev.yml (1)

68-68: 하위 호환을 위한 폴백 환경변수 연결 제안

여러 실행 환경(로컬 .env, CI/CD, 배포 시크릿)에 아직 옛 키가 남아 있을 수 있습니다. 당장 깨짐을 방지하려면 새 키가 없을 때 구 키로 폴백하도록 설정을 한 줄로 완화할 수 있습니다.

아래 변경을 고려해 주세요:

-      bucket: ${AWS_TEST_RESOURCE_BUCKET}
+      bucket: ${AWS_TEST_RESOURCE_BUCKET:${WS_TEST_RESOURCE_BUCKET}}
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4637d62 and 2867783.

📒 Files selected for processing (1)
  • gdgoc/src/main/resources/application-dev.yml (1 hunks)
🔇 Additional comments (2)
gdgoc/src/main/resources/application-dev.yml (2)

68-68: 오타 교정 적절 — 표준 AWS 환경변수 네이밍과 일치합니다.

Line 68에서 ${WS_TEST_RESOURCE_BUCKET}${AWS_TEST_RESOURCE_BUCKET} 변경은 의도와 일치하며, 기존의 AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_REGION 키들과 네이밍 일관성도 좋아졌습니다.


60-69: 레거시 WS_TEST_RESOURCE_BUCKET 키 미검출 및 신규 키(AWS_TEST_RESOURCE_BUCKET) 사용 현황

전역 검색 결과, 레거시 키(WS_TEST_RESOURCE_BUCKET)는 레포에서 발견되지 않았으며, 아래 파일들에는 모두 신규 키(AWS_TEST_RESOURCE_BUCKET)만 사용 중임을 확인했습니다.

  • .github/workflows/deploy-prod.yml·deploy-dev.yml (워크플로우에서 .env 생성 시)
  • gdgoc/src/main/resources/application-dev.yml, application-local.yml
  • gdgoc/src/main/java/inha/gdgoc/config/DotenvLoader.java 스크립트 출력

추가 검토가 필요한 항목

  • gdgoc/docker-compose-dev.yml, gdgoc/docker-compose-prod.ymlenvironment 섹션에 AWS_TEST_RESOURCE_BUCKET 정의 여부
  • CI/CD 워크플로우(.github/workflows/deploy-*.yml)의 시크릿(secrets.AWS_TEST_RESOURCE_BUCKET) 동기화 상태

위 위치에 신규 키가 누락되어 있다면, AWS_TEST_RESOURCE_BUCKET으로 추가·동기화해 주세요.

@kaswhy kaswhy merged commit b16b8b9 into develop Aug 23, 2025
3 checks passed
@kaswhy kaswhy deleted the feature/issue-70 branch August 23, 2025 12:06
@coderabbitai coderabbitai bot mentioned this pull request Aug 24, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants