Skip to content

Conversation

@pwc2002
Copy link
Contributor

@pwc2002 pwc2002 commented Sep 1, 2025

📌 연관된 이슈

이슈 미생성

✨ 작업 내용

FE 개발 도메인 추가에 따른, be 개발 도메인 dev 도메인으로 이전

💬 리뷰 요구사항(선택)

Summary by CodeRabbit

  • 신기능
    • 새로운 접근 도메인 https://dev.gdgocinha.com 을 CORS 허용 목록에 추가했습니다. 이제 해당 도메인에서 로그인, API 호출, 리소스 로딩이 브라우저 차단 없이 정상 동작합니다. 기존 허용 도메인(로컬호스트, 메인/WWW, Vercel 프리뷰)은 변경 없이 유지됩니다. 사용자 측면의 추가 설정은 필요 없습니다. 이로써 개발 환경에서의 테스트 및 사용성이 향상됩니다.

@pwc2002 pwc2002 self-assigned this Sep 1, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 1, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

CORS 설정에서 허용 origin 목록에 https://dev.gdgocinha.com 이 추가되었습니다. 기존 허용 origin들은 유지되며, 메서드 시그니처와 제어 흐름 변경은 없습니다.

Changes

Cohort / File(s) Summary
CORS 설정 업데이트
src/main/java/inha/gdgoc/global/security/SecurityConfig.java
CorsConfigurationSource에 허용 origin로 https://dev.gdgocinha.com 추가. 기존 origin 목록은 유지. 다른 로직/시그니처 변경 없음.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • [HOTFIX] CORS 해결 #208 — 같은 SecurityConfig에서 CORS 설정을 수정하며, 해당 PR은 허용 메서드/프리플라이트 처리 조정에 초점을 둬 변경 영역이 인접합니다.

Poem

새싹 도메인, 푸른 바람에 살짝 추가됐지요 🌿
토끼는 귀를 쫑긋, CORS 문을 한 칸 더 열고
dev 별빛도 통과하도록 별을 놓아요 ✨
로직은 그대로, 주소만 살짝—
깡총깡총, 배포 길도 한층 가벼워라 🐇


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3b5bcf2 and 9ee388b.

📒 Files selected for processing (1)
  • src/main/java/inha/gdgoc/global/security/SecurityConfig.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/issue-209

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pwc2002 pwc2002 merged commit 5909b8f into develop Sep 1, 2025
1 check passed
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

CI status
✅ Assemble 성공
✅ Test 성공

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants