This repository was archived by the owner on Oct 26, 2021. It is now read-only.
Pass INVALID_ID to auto-generate layer ID#19
Open
gunnarx wants to merge 1 commit intoGENIVI:masterfrom
Open
Conversation
gunnarx
force-pushed
the
use_invalid_id_not_zero
branch
4 times, most recently
from
ed77306 to
4a09142
Compare
A layer ID of zero is not correct. I am guessing that the previous
intention was to use zero to generate an automatic ID, and the ILM
documentation incorrectly said that it would (upstream bug [LM-6]).
INVALID_ID should be passed instead, to get a generated ID.
The parameter to helper function createLayer() must now be passed by
reference so that the member variable m_backgroundSurfaceId can be
assigned the right value. The layer ID used to be constant (zero) and
therefore this was not the case before.
[GDP-778] wayland-ivi-extension layer id integration issues from P-0.1
and P-1.0 upgrade
[LM-6] Documentation for ilm_layerCreateWithDimension() is wrong
regarding creating new ID automatically?
Signed-off-by: Gunnar Andersson <gandersson@genivi.org>
layercontroller: debug printouts (WIP)
Revert "hmicontroller: Pass INVALID_ID to auto-generate layer ID"
This reverts commit 4a09142.
Redo debug and createlayer-by-ref
gunnarx
force-pushed
the
use_invalid_id_not_zero
branch
from
4a09142 to
dc97376
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An idea to fix layer ID issues. I have neither compiled or tested yet. And also no feedback on LM-6 yet, so this is just an assumption that it is valid. Work in progress...
Please read the full comment, and info in GDP-778 and LM-6 for details.